Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Use bthread lock in merge commit rpc #54575

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[Enhancement] Use bthread lock in merge commit rpc #54575

merged 1 commit into from
Jan 3, 2025

Conversation

banmoy
Copy link
Contributor

@banmoy banmoy commented Jan 1, 2025 •
edited
Loading

Why I'm doing:

using std lock in brpc request can block brpc threads

What I'm doing:

use bthread lock instead

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@banmoy
Use bthread mutex in rpc
173d74f 
Signed-off-by: PengFei Li <[email protected]>
@banmoy banmoy requested a review from a team as a code owner January 1, 2025 13:23
@mergify mergify bot assigned banmoy Jan 1, 2025
@banmoy banmoy changed the title [Enhancement] replace std lock with bthread lock in merge commit request [Enhancement] Use bthread lock in merge commit brpc request Jan 1, 2025
@banmoy banmoy changed the title [Enhancement] Use bthread lock in merge commit brpc request [Enhancement] Use bthread lock in merge commit rpc Jan 1, 2025
@github-actions github-actions bot added the 3.4 label Jan 1, 2025
@banmoy
Copy link
Contributor Author

banmoy commented Jan 2, 2025

@mergify rerun

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

rerun

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

[BE Incremental Coverage Report]

✅ pass : 14 / 14 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/batch_write/batch_write_mgr.cpp 3 3 100.00% []
🔵 be/src/runtime/batch_write/isomorphic_batch_write.cpp 11 11 100.00% []

@wyb wyb merged commit 827547a into StarRocks:main Jan 3, 2025
69 of 74 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 3, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@banmoy @mergify
[Enhancement] Use bthread lock in merge commit rpc (#54575)
e0f29a0 
Signed-off-by: PengFei Li <[email protected]>
(cherry picked from commit 827547a)
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
@banmoy
Copy link
Contributor Author

banmoy commented Jan 3, 2025

@Mergifyio backport branch-3.4.0-rc01

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.4.0-rc01

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@banmoy @mergify
[Enhancement] Use bthread lock in merge commit rpc (#54575)
d181755 
Signed-off-by: PengFei Li <[email protected]>
(cherry picked from commit 827547a)
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @banmoy
[Enhancement] Use bthread lock in merge commit rpc (backport #54575) (#…
9240c3f 
…54640)

Co-authored-by: PengFei Li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 3, 2025
@mergify @banmoy
[Enhancement] Use bthread lock in merge commit rpc (backport #54575) (#…
c276a82 
…54641)

Co-authored-by: PengFei Li <[email protected]>
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
@banmoy
[Enhancement] Use bthread lock in merge commit rpc (StarRocks#54575)
62275f1 
Signed-off-by: PengFei Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@wyb wyb wyb approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@banmoy banmoy

Labels
3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banmoy @kevincai @wyb