Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support restoring from a cluster snapshot for shared-data mode (part 3, introduce gtid for tablet metadata) (backport #54326) #54450

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 27, 2024

Why I'm doing:

The dirty data must be detected when restoring from a cluster snapshot.

What I'm doing:

Introduce gtid for tablet metadata, gtid will be used for the following:

  1. Check if a tablet metadata version is dirty using gtid during publish version. If the gtid of a tablet metadata version is not equal to the value saved in fe, it indicates that the tablet metadata version is dirty and need to be deleted.
  2. Query versions before a given time for time travel, like select a from b before t.

Fixes #53867

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…ode (part 3, introduce gtid for tablet metadata) (#54326)

Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit f977337)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/task/CreateReplicaTask.java
#	fe/fe-core/src/main/java/com/starrocks/task/TabletTaskExecutor.java
#	gensrc/proto/lake_types.proto
#	gensrc/thrift/AgentService.thrift
@mergify mergify bot added the conflicts label Dec 27, 2024
Copy link
Contributor Author

mergify bot commented Dec 27, 2024

Cherry-pick of f977337 has failed:

On branch mergify/bp/branch-3.4/pr-54326
Your branch is up to date with 'origin/branch-3.4'.

You are currently cherry-picking commit f977337f8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/storage/lake/tablet_manager.cpp
	modified:   be/src/storage/lake/transactions.cpp
	modified:   fe/fe-core/src/main/java/com/starrocks/alter/LakeRollupJob.java
	modified:   fe/fe-core/src/main/java/com/starrocks/alter/LakeTableAlterMetaJobBase.java
	modified:   fe/fe-core/src/main/java/com/starrocks/alter/LakeTableSchemaChangeJob.java
	modified:   fe/fe-core/src/main/java/com/starrocks/alter/LakeTableSchemaChangeJobBase.java
	modified:   fe/fe-core/src/main/java/com/starrocks/lake/TxnInfoHelper.java
	modified:   fe/fe-core/src/main/java/com/starrocks/server/LocalMetastore.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/task/CreateReplicaTask.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/task/TabletTaskExecutor.java
	both modified:   gensrc/proto/lake_types.proto
	both modified:   gensrc/thrift/AgentService.thrift

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Dec 27, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@andyziye andyziye reopened this Dec 27, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 27, 2024 08:09
Signed-off-by: xiangguangyxg <[email protected]>
@wanpengfei-git wanpengfei-git merged commit ff61e88 into branch-3.4 Dec 27, 2024
29 of 30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-54326 branch December 27, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants