[Feature] support event scheduler (part 1) #54260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
stdpain
force-pushed
the
cmt_event_based_scheduler
branch
2 times, most recently
from
9ddad58 to
4eb5909
Compare
Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
cmt_event_based_scheduler
branch
2 times, most recently
from
4e53bf9 to
edab262
Compare
Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
cmt_event_based_scheduler
branch
from
edab262 to
cc8f32d
Compare
Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
cmt_event_based_scheduler
branch
from
54a4fac to
142ea2a
Compare
Signed-off-by: stdpain <[email protected]>
stdpain
changed the title
stdpain
changed the title
Signed-off-by: stdpain <[email protected]>
Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
cmt_event_based_scheduler
branch
from
3c15229 to
8d6abcf
Compare
Signed-off-by: stdpain <[email protected]>
Signed-off-by: stdpain <[email protected]>
Signed-off-by: stdpain <[email protected]>
satanson
reviewed
Dec 25, 2024
Signed-off-by: stdpain <[email protected]>
stdpain
force-pushed
the
cmt_event_based_scheduler
branch
from
d6b4d28 to
2428618
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 156 / 169 (92.31%) file detail
|
satanson
approved these changes
Dec 25, 2024
kevincai
approved these changes
Dec 25, 2024
kevincai
reviewed
Dec 25, 2024
| @@ -174,6 +175,10 @@ class FragmentContext { | |||
| // acquire runtime filter from cache | |||
| void acquire_runtime_filters(); | |||
|
|
|||
| bool enable_event_scheduler() const { return event_scheduler() != nullptr; } | |||
There was a problem hiding this comment.
nit: shall it be event_scheduler_enabled? enable_event_scheduler reads like to perform an action, turn on the event_scheduler, not query the on/off status.
There was a problem hiding this comment.
our session variables style is enable_xxx_feature
DorianZheng
approved these changes
Dec 25, 2024
maggie-zhu
pushed a commit
to maggie-zhu/starrocks
that referenced
this pull request
Jan 6, 2025
Signed-off-by: stdpain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm doing:
Adds tool class for event scheduler
link #54259
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: