-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Optimize merge commit performance #54251
Merged
Merged
+179
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banmoy
force-pushed
the
fix_merge_commit_opt
branch
3 times, most recently
from
December 24, 2024 08:23
fbb8c63
to
42e800e
Compare
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
banmoy
force-pushed
the
fix_merge_commit_opt
branch
from
December 24, 2024 10:51
e63a755
to
7549f89
Compare
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 56 / 64 (87.50%) file detail
|
kevincai
approved these changes
Dec 25, 2024
wyb
approved these changes
Dec 26, 2024
trueeyu
approved these changes
Dec 27, 2024
@Mergifyio backport branch-3.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
Signed-off-by: PengFei Li <[email protected]> (cherry picked from commit ba15dfc)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 27, 2024
Co-authored-by: PengFei Li <[email protected]>
@Mergifyio backport branch-3.4.0-rc01 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
Signed-off-by: PengFei Li <[email protected]> (cherry picked from commit ba15dfc)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 27, 2024
Co-authored-by: PengFei Li <[email protected]>
maggie-zhu
pushed a commit
to maggie-zhu/starrocks
that referenced
this pull request
Jan 6, 2025
Signed-off-by: PengFei Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Optimize the performance of merge commit under high pressure load
What I'm doing:
butil::ip2str
to get the ip of the client rather thanbutil::ip2hostname
.ip2hostname
may communicate with DNS server which causes second-level latency jitter. See BatchWriteMgr::receive_stream_load_rpcIOTaskWaitTime
is large. So adjust the time from 50ms to 500us. 500us is an empirical value under the high concurrency load. After the pipeline engine supports event-based scheduling, we can reimplement it with the input-driven instead of polling. See BatchWriteMgr::create_and_register_pipeFixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: