Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Optimize merge commit performance #54251

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

banmoy
Copy link
Contributor

@banmoy banmoy commented Dec 24, 2024

Why I'm doing:

Optimize the performance of merge commit under high pressure load

What I'm doing:

  1. append data to stream load pipe may block if consuming the pipe is slow, so move the append outside the lock. See IsomorphicBatchWrite::_write_data_to_pipe
  2. use butil::ip2str to get the ip of the client rather than butil::ip2hostname. ip2hostname may communicate with DNS server which causes second-level latency jitter. See BatchWriteMgr::receive_stream_load_rpc
  3. pipeline engine will poll the stream load pipe to read the data. Each poll will wait for some time in the pipeline connector scan executor to avoid polling frequently. If the time is large, it will block other tasks which lead to the profile metric IOTaskWaitTime is large. So adjust the time from 50ms to 500us. 500us is an empirical value under the high concurrency load. After the pipeline engine supports event-based scheduling, we can reimplement it with the input-driven instead of polling. See BatchWriteMgr::create_and_register_pipe
  4. improve the error message. See IsomorphicBatchWrite::_execute_write

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@banmoy banmoy requested review from a team as code owners December 24, 2024 02:22
@mergify mergify bot assigned banmoy Dec 24, 2024
@github-actions github-actions bot added the 3.4 label Dec 24, 2024
@banmoy banmoy force-pushed the fix_merge_commit_opt branch 3 times, most recently from fbb8c63 to 42e800e Compare December 24, 2024 08:23
Signed-off-by: PengFei Li <[email protected]>
@banmoy banmoy force-pushed the fix_merge_commit_opt branch from e63a755 to 7549f89 Compare December 24, 2024 10:51
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 56 / 64 (87.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/runtime/stream_load/time_bounded_stream_load_pipe.h 0 1 00.00% [32]
🔵 be/src/runtime/batch_write/isomorphic_batch_write.cpp 47 54 87.04% [240, 302, 303, 308, 317, 365, 366]
🔵 be/src/runtime/stream_load/stream_load_pipe.cpp 2 2 100.00% []
🔵 be/src/runtime/batch_write/batch_write_mgr.cpp 5 5 100.00% []
🔵 be/src/runtime/stream_load/stream_load_pipe.h 2 2 100.00% []

@wyb wyb enabled auto-merge (squash) December 26, 2024 08:46
@wyb wyb merged commit ba15dfc into StarRocks:main Dec 27, 2024
83 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Dec 27, 2024
Copy link
Contributor

mergify bot commented Dec 27, 2024

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 27, 2024
Signed-off-by: PengFei Li <[email protected]>
(cherry picked from commit ba15dfc)
wanpengfei-git pushed a commit that referenced this pull request Dec 27, 2024
@banmoy
Copy link
Contributor Author

banmoy commented Dec 27, 2024

@Mergifyio backport branch-3.4.0-rc01

Copy link
Contributor

mergify bot commented Dec 27, 2024

backport branch-3.4.0-rc01

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 27, 2024
Signed-off-by: PengFei Li <[email protected]>
(cherry picked from commit ba15dfc)
wanpengfei-git pushed a commit that referenced this pull request Dec 27, 2024
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants