Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support restoring from a cluster snapshot for shared-data mode (part 2, update metadata during restoring) #54128

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[Feature] Support restoring from a cluster snapshot for shared-data mode (part 2, update metadata during restoring) #54128

merged 1 commit into from
Dec 23, 2024

Conversation

xiangguangyxg
Copy link
Contributor

@xiangguangyxg xiangguangyxg commented Dec 19, 2024 •
edited
Loading

Why I'm doing:

To support disaster recovery for shared-data mode.

What I'm doing:

Update metadata during restoring from a cluster snapshot according to the cluster_snapshot.yaml

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@xiangguangyxg
[Feature] Support restoring from a cluster snapshot for shared-data m…
14f8cca 
…ode (part 2, update metadata during restoring)

Signed-off-by: xiangguangyxg <[email protected]>
@andyziye andyziye linked an issue Dec 20, 2024 that may be closed by this pull request
shared-data mode support backup restore though automated snapshot #53867
Closed
7 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 56 / 66 (84.85%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/lake/snapshot/RestoreClusterSnapshotMgr.java 38 48 79.17% [71, 100, 106, 107, 108, 121, 133, 134, 136, 149]
🔵 com/starrocks/server/StorageVolumeMgr.java 14 14 100.00% []
🔵 com/starrocks/storagevolume/StorageVolume.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@gengjun-git gengjun-git self-assigned this Dec 20, 2024
@HangyuanLiu HangyuanLiu self-assigned this Dec 20, 2024
@gengjun-git gengjun-git merged commit 2ad831b into StarRocks:main Dec 23, 2024
58 checks passed
@wanpengfei-git wanpengfei-git mentioned this pull request Dec 23, 2024
Closed
7 tasks
@xiangguangyxg
Copy link
Contributor Author

@mergify backport branch-3.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 23, 2024
@xiangguangyxg @mergify
[Feature] Support restoring from a cluster snapshot for shared-data m…
e18ca07 
…ode (part 2, update metadata during restoring) (#54128)

## Why I'm doing:
To support disaster recovery for shared-data mode.

## What I'm doing:
Update metadata during restoring from a cluster snapshot according to the `cluster_snapshot.yaml`

Signed-off-by: xiangguangyxg <[email protected]>
(cherry picked from commit 2ad831b)
@mergify mergify bot mentioned this pull request Dec 23, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Dec 23, 2024
@mergify @xiangguangyxg
[Feature] Support restoring from a cluster snapshot for shared-data m…
9da9ea1 
…ode (part 2, update metadata during restoring) (backport #54128) (#54212)

Co-authored-by: xiangguangyxg <[email protected]>
@xiangguangyxg xiangguangyxg deleted the restore_snapshot_update_meta branch December 23, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@HangyuanLiu HangyuanLiu HangyuanLiu approved these changes

Assignees

@HangyuanLiu HangyuanLiu

@gengjun-git gengjun-git

@xiangguangyxg xiangguangyxg

Labels
3.4-merged version:3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shared-data mode support backup restore though automated snapshot
3 participants
@xiangguangyxg @HangyuanLiu @gengjun-git