Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize partition retention condition compensation rewrite performance in force_mv mode #54072

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Dec 18, 2024

Why I'm doing:

What I'm doing:

Fixes #53117

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@LiShuMing LiShuMing requested review from a team as code owners December 18, 2024 14:55
@LiShuMing LiShuMing changed the title [Refactor] [WIP] Refactor mv compensation [UT] [Refactor] [WIP] Refactor mv compensation Dec 18, 2024
@LiShuMing LiShuMing changed the title [UT] [Refactor] [WIP] Refactor mv compensation [Refactor] [WIP] Refactor mv compensation Dec 19, 2024
@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch from 060ad01 to ad39d68 Compare December 19, 2024 08:54
@LiShuMing LiShuMing requested a review from a team as a code owner December 19, 2024 08:54
@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch 2 times, most recently from eb49de3 to 1751598 Compare December 19, 2024 09:00
@LiShuMing LiShuMing changed the title [Refactor] [WIP] Refactor mv compensation [Refactor] Refactor mv partition compensation Dec 19, 2024
@LiShuMing LiShuMing changed the title [Refactor] Refactor mv partition compensation [UT] [Refactor] Refactor mv partition compensation Dec 19, 2024
@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch 3 times, most recently from f0e6119 to 8f59671 Compare December 23, 2024 06:10
@LiShuMing LiShuMing changed the title [UT] [Refactor] Refactor mv partition compensation [Refactor] [WIP] Refactor mv partition compensation Dec 24, 2024
@LiShuMing
Copy link
Contributor Author

@mergify rebase

Copy link
Contributor

mergify bot commented Dec 24, 2024

rebase

✅ Branch has been successfully rebased

@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch from df49bc0 to 40179c8 Compare December 24, 2024 04:45
@LiShuMing LiShuMing changed the title [Refactor] [WIP] Refactor mv partition compensation [UT] [Refactor] [WIP] Refactor mv partition compensation Dec 25, 2024
@LiShuMing LiShuMing changed the title [UT] [Refactor] [WIP] Refactor mv partition compensation [UT] [Enhancement] [WIP] Support partition retention condition compensation in force_mv rewrite mode Dec 26, 2024
@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch from e9f58a0 to 8b5d3d7 Compare December 26, 2024 08:39
@LiShuMing LiShuMing changed the title [UT] [Enhancement] [WIP] Support partition retention condition compensation in force_mv rewrite mode [Enhancement] [WIP] Support partition retention condition compensation in force_mv rewrite mode Dec 27, 2024
@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch from 8b5d3d7 to 48381e0 Compare January 2, 2025 07:11
@LiShuMing LiShuMing changed the title [Enhancement] [WIP] Support partition retention condition compensation in force_mv rewrite mode [Enhancement] Support partition retention condition compensation in force_mv rewrite mode Jan 2, 2025
@LiShuMing LiShuMing changed the title [Enhancement] Support partition retention condition compensation in force_mv rewrite mode [Enhancement] Optimize partition retention condition compensation rewrite performance in force_mv mode Jan 3, 2025
@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch from ac0c138 to 6ae689a Compare January 3, 2025 10:00
@LiShuMing LiShuMing force-pushed the refactor_mv_compensation branch from 6ae689a to 9b66a1f Compare January 3, 2025 10:13
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarqubecloud bot commented Jan 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

github-actions bot commented Jan 4, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 4, 2025

[FE Incremental Coverage Report]

pass : 196 / 239 (82.01%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/alter/AlterJobMgr.java 0 2 00.00% [420, 421]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MVCompensationPruneUnionRule.java 23 46 50.00% [52, 72, 75, 79, 87, 88, 89, 90, 92, 97, 98, 99, 100, 103, 104, 105, 106, 107, 109, 110, 111, 113, 114]
🔵 com/starrocks/sql/optimizer/rewrite/ScalarOperatorEvaluator.java 1 2 50.00% [205]
🔵 com/starrocks/sql/optimizer/CachingMvPlanContextBuilder.java 3 5 60.00% [206, 207]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/compensation/PartitionRetentionTableCompensation.java 31 37 83.78% [53, 68, 83, 95, 98, 99]
🔵 com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java 37 42 88.10% [1861, 1862, 1865, 1883, 1904]
🔵 com/starrocks/catalog/MaterializedView.java 21 23 91.30% [1509, 1860]
🔵 com/starrocks/scheduler/mv/MVVersionManager.java 18 19 94.74% [78]
🔵 com/starrocks/scheduler/mv/MVTimelinessMgr.java 28 29 96.55% [78]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/compensation/OptCompensator.java 1 1 100.00% []
🔵 com/starrocks/catalog/mv/MVTimelinessArbiter.java 3 3 100.00% []
🔵 com/starrocks/sql/optimizer/rule/RuleType.java 1 1 100.00% []
🔵 com/starrocks/alter/AlterMVJobExecutor.java 1 1 100.00% []
🔵 com/starrocks/scheduler/mv/MaterializedViewMgr.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MvPartitionCompensator.java 6 6 100.00% []
🔵 com/starrocks/sql/optimizer/Optimizer.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/QueryMaterializationContext.java 6 6 100.00% []
🔵 com/starrocks/memory/MemoryUsageTracker.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/compensation/MVCompensationBuilder.java 10 10 100.00% []

Copy link

github-actions bot commented Jan 4, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support TTL for List Partition Tables and Materialized Views
1 participant