Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Trino dialect, the extract function supports dow and week parameters #52651

Merged
merged 12 commits into from
Nov 19, 2024

Conversation

renzhimin7
Copy link
Contributor

@renzhimin7 renzhimin7 commented Nov 5, 2024

Why I'm doing:

extract(dow FROM TIMESTAMP '2022-10-20 05:10:00') not support trino dialect.

set sql_dialect='trino';
SELECT extract(dow FROM TIMESTAMP '2022-10-20 05:10:00');
ERROR 1064 (HY000): Getting analyzing error. Detail message: No matching function with signature: dow(datetime).

What I'm doing:

Fixes #52698

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.5

@renzhimin7 renzhimin7 requested a review from a team as a code owner November 5, 2024 16:05
miomiocat
miomiocat previously approved these changes Nov 7, 2024
@miomiocat miomiocat enabled auto-merge (squash) November 7, 2024 11:17
auto-merge was automatically disabled November 8, 2024 08:34

Head branch was pushed to by a user without write access

Youngwb
Youngwb previously approved these changes Nov 12, 2024
trueeyu
trueeyu previously approved these changes Nov 14, 2024
@Youngwb Youngwb enabled auto-merge (squash) November 15, 2024 12:20
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/parser/trino/AstBuilder.java 5 5 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Youngwb Youngwb merged commit 7616df3 into StarRocks:main Nov 19, 2024
47 checks passed
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trino dialect the extract function not supports dow and week parameters
5 participants