Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix stale mem flush not reduce load memory usage #52613

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Nov 5, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@meegoo meegoo requested review from a team as code owners November 5, 2024 06:14
@mergify mergify bot assigned meegoo Nov 5, 2024
@github-actions github-actions bot added the 3.3 label Nov 5, 2024
@meegoo meegoo force-pushed the fix_stale_flush branch 3 times, most recently from e0f123e to 7016dbf Compare November 6, 2024 02:56
wyb
wyb previously approved these changes Nov 6, 2024
@meegoo meegoo enabled auto-merge (squash) November 7, 2024 04:55
Copy link

github-actions bot commented Nov 7, 2024

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 7, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 7, 2024

[BE Incremental Coverage Report]

pass : 13 / 13 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/async_delta_writer.cpp 1 1 100.00% []
🔵 be/src/storage/lake/delta_writer.cpp 7 7 100.00% []
🔵 be/src/storage/delta_writer.cpp 4 4 100.00% []
🔵 be/src/storage/lake/async_delta_writer.cpp 1 1 100.00% []

@meegoo meegoo merged commit 2ec626e into StarRocks:main Nov 7, 2024
44 checks passed
Copy link

github-actions bot commented Nov 7, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 7, 2024
Signed-off-by: meegoo <[email protected]>
(cherry picked from commit 2ec626e)

# Conflicts:
#	be/src/storage/delta_writer.h
#	be/src/storage/lake/async_delta_writer.cpp
#	be/test/storage/lake/async_delta_writer_test.cpp
#	test/sql/test_automatic_bucket/R/test_automatic_partition
#	test/sql/test_automatic_bucket/T/test_automatic_partition
meegoo added a commit that referenced this pull request Nov 8, 2024
mergify bot added a commit that referenced this pull request Nov 8, 2024
…52613) (#52713)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: meegoo <[email protected]>
(cherry picked from commit b57cc09)

# Conflicts:
#	test/sql/test_automatic_bucket/R/test_automatic_partition
#	test/sql/test_automatic_bucket/T/test_automatic_partition
meegoo added a commit that referenced this pull request Nov 8, 2024
…52613) (backport #52713) (#52730)

Signed-off-by: meegoo <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: meegoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants