Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add metrics for pk table error state #52590

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[Enhancement] add metrics for pk table error state #52590

merged 2 commits into from
Nov 5, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Nov 4, 2024 •
edited
Loading

Why I'm doing:

Primary table's error state means internal check fail with unrecoverable consistency issue, this is serious issue so we need add metrics and alert to it.

What I'm doing:

This pull request introduces new metrics to track the error states of primary key tables and integrates them into various parts of the primary key table. The key changes include adding a new metric, updating error handling to increment this metric, and ensuring the metric is registered correctly.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested review from a team as code owners November 4, 2024 12:01
@mergify mergify bot assigned luohaha Nov 4, 2024
wyb
wyb previously approved these changes Nov 4, 2024
View reviewed changes
sevev
sevev previously approved these changes Nov 4, 2024
View reviewed changes
dirtysalt
dirtysalt previously approved these changes Nov 4, 2024
View reviewed changes
@luohaha luohaha enabled auto-merge (squash) November 4, 2024 12:11
@luohaha luohaha dismissed stale reviews from dirtysalt, sevev, and wyb via 61c8225 November 5, 2024 02:25
@luohaha
add UT
b6de127 
Signed-off-by: luohaha <[email protected]>
@luohaha luohaha force-pushed the improve-pk-recover branch from 79e8003 to b6de127 Compare November 5, 2024 03:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

[BE Incremental Coverage Report]

✅ pass : 4 / 5 (80.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/update_manager.cpp 1 2 50.00% [305]
🔵 be/src/storage/lake/meta_file.cpp 1 1 100.00% []
🔵 be/src/util/starrocks_metrics.cpp 1 1 100.00% []
🔵 be/src/storage/tablet_updates.cpp 1 1 100.00% []

@luohaha luohaha merged commit 7c45354 into StarRocks:main Nov 5, 2024
44 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 5, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 5, 2024
@luohaha @mergify
[Enhancement] add metrics for pk table error state (#52590)
b1bbabf 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 7c45354)
@mergify mergify bot mentioned this pull request Nov 5, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
@luohaha @mergify
[Enhancement] add metrics for pk table error state (#52590)
8d974c2 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 7c45354)
mergify bot pushed a commit that referenced this pull request Nov 5, 2024
@luohaha @mergify
[Enhancement] add metrics for pk table error state (#52590)
c3b695e 
Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 7c45354)

# Conflicts:
#	be/test/storage/lake/meta_file_test.cpp
This was referenced Nov 5, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 5, 2024
@mergify @luohaha
[Enhancement] add metrics for pk table error state (backport #52590) (#…
a68f381 
…52609)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Nov 5, 2024
@mergify @luohaha
[Enhancement] add metrics for pk table error state (backport #52590) (#…
9be095c 
…52610)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Nov 5, 2024
@mergify @luohaha
[Enhancement] add metrics for pk table error state (backport #52590) (#…
b917805 
…52611)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@luohaha @renzhimin7
[Enhancement] add metrics for pk table error state (StarRocks#52590)
2f4376e 
Signed-off-by: luohaha <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

@wyb wyb wyb approved these changes

@sevev sevev sevev left review comments

Assignees

@luohaha luohaha

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luohaha @wyb @dirtysalt @sevev