[Enhancement] Use more clear type description in ParquetField #52575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Smith Cruise <[email protected]>
Smith-Cruise
commented
Nov 4, 2024
| #if defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) || defined(THREAD_SANITIZER) | ||
| LOG(INFO) << "Memory tracking is not available with address sanitizer builds."; | ||
| #else | ||
| size_t value = 0; |
There was a problem hiding this comment.
fix asan compile warning: unused values
Signed-off-by: Smith Cruise <[email protected]>
Signed-off-by: Smith Cruise <[email protected]>
Smith-Cruise
changed the title
Smith-Cruise
commented
Nov 4, 2024
| @@ -262,13 +259,7 @@ Status SchemaDescriptor::group_to_struct_field(const std::vector<tparquet::Schem | |||
| field->name = group_schema->name; | |||
| field->is_nullable = is_optional(group_schema); | |||
| field->level_info = cur_level_info; | |||
| field->type.type = TYPE_STRUCT; | |||
| for (size_t i = 0; i < num_children; i++) { | |||
There was a problem hiding this comment.
never used children
zombee0
approved these changes
Nov 4, 2024
dirtysalt
previously approved these changes
Nov 4, 2024
be/src/formats/parquet/schema.h
Outdated
| @@ -89,12 +89,29 @@ struct LevelInfo { | |||
| std::string debug_string() const; | |||
| }; | |||
|
|
|||
| enum ColumnType { SCALAR = 0, ARRAY, MAP, STRUCT }; | |||
|
|
|||
| inline std::string column_type_to_string(const ColumnType& column_type) { | |||
There was a problem hiding this comment.
because this function is not necessary to be inlined for performance. It will be good for compile performance if you move it into cpp files.
be/src/formats/parquet/schema.h
Outdated
| @@ -118,6 +135,19 @@ struct ParquetField { | |||
| int16_t max_def_level() const { return level_info.max_def_level; } | |||
| int16_t max_rep_level() const { return level_info.max_rep_level; } | |||
| std::string debug_string() const; | |||
| bool is_complex_type() const { return type == ARRAY || type == MAP || type == STRUCT; } | |||
| bool has_same_complex_type(const TypeDescriptor& type_descriptor) const { | |||
Signed-off-by: Smith Cruise <[email protected]>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 42 / 49 (85.71%) file detail
|
dirtysalt
approved these changes
Nov 5, 2024
stephen-shelby
approved these changes
Nov 5, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Smith Cruise <[email protected]> (cherry picked from commit 1028b6a) # Conflicts: # be/src/formats/parquet/column_reader.cpp # be/src/formats/parquet/group_reader.cpp # be/src/formats/parquet/meta_helper.cpp # be/src/formats/parquet/schema.cpp # be/test/formats/parquet/group_reader_test.cpp
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Smith Cruise <[email protected]> (cherry picked from commit 1028b6a) # Conflicts: # be/src/formats/parquet/column_reader.cpp # be/src/formats/parquet/group_reader.cpp # be/src/formats/parquet/schema.cpp # be/test/formats/parquet/group_reader_test.cpp
This was referenced Nov 5, 2024
24 tasks
dirtysalt
pushed a commit
that referenced
this pull request
Nov 5, 2024
…n in ParquetField (backport #52575) (#52635) Signed-off-by: Smith Cruise <[email protected]>
24 tasks
dirtysalt
pushed a commit
that referenced
this pull request
Nov 6, 2024
…n in ParquetField (backport #52575) (#52642) Signed-off-by: Smith Cruise <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…cks#52575) Signed-off-by: Smith Cruise <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In the previous code, we used TypeDescriptor to represent type in ParquetField.
But actually, we will only set TypeDescriptor when ParquetField is a complex type, for scalar type, we will set a random value for it. it will easily mislead programmers.
What I'm doing:
Use a more strict type
ColumnTypeto replace TypeDescriptor.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: