Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix local file rename in broker (backport #52544) #52553

Merged
merged 1 commit into from
Nov 2, 2024
Merged

[BugFix] Fix local file rename in broker (backport #52544) #52553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...dfs_broker/src/broker-core/src/main/java/com/starrocks/broker/hdfs/FileSystemManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,8 +983,12 @@ public void deletePath(String path, Map<String, String> properties) {

public void renamePath(String srcPath, String destPath, Map<String, String> properties) {
WildcardURI srcPathUri = new WildcardURI(srcPath);
String srcAuthority = srcPathUri.getAuthority();
WildcardURI destPathUri = new WildcardURI(destPath);
if (!srcPathUri.getAuthority().trim().equals(destPathUri.getAuthority().trim())) {
String destAuthority = destPathUri.getAuthority();
// the authority of local file path is null, like file:///xxx.
// skip check when the authority is null.
if (srcAuthority != null && destAuthority != null && !srcAuthority.trim().equals(destAuthority.trim())) {
throw new BrokerException(TBrokerOperationStatusCode.TARGET_STORAGE_SERVICE_ERROR,
"only allow rename in same file system");
}
Expand Down
Loading