[Enhancement] pushdown runtime filter when cbo_agg_push is enabled and join type is broadcast and rf builded from colocate group (backport #52506) #52546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…d join type is broadcast and rf builded from colocate group (#52506) Signed-off-by: stephen <[email protected]> (cherry picked from commit aed02ae)
24 tasks
|
stephen-shelby
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
fix tpcds bad case when agg pushdown enabled.
What I'm doing:
pushdown runtime filter to exchange node when rf is builded from broadcast join and colocate group.
Because the rf generated by broadcast join is full, it can be pushed down for this case like query58.
tpcds-100g q58 comparison results with agg_pushdown enabled
this patch will not cause performance degradation of other tpcds queries by test.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #52506 done by [Mergify](https://mergify.com). ## Why I'm doing: fix tpcds bad case when agg pushdown enabled. ## What I'm doing: pushdown runtime filter to exchange node when rf is builded from broadcast join and colocate group. Because the rf generated by broadcast join is full, it can be pushed down for this case like query58.
tpcds-100g q58 comparison results with agg_pushdown enabled
this patch will not cause performance degradation of other tpcds queries by test.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: