Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix error scan operator's column order in the IcebergEqualityDeleteRewriteRule. #52510

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Oct 31, 2024

Why I'm doing:

What I'm doing:

Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/8771

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stephen-shelby stephen-shelby requested a review from a team as a code owner October 31, 2024 15:15
newColRefToColBuilder.put(originToNewCols.get(deleteColRef), deleteCol);
}
}

fillExtendedColumns(columnRefFactory, newColRefToColBuilder, newColToColRefBuilder, hasPartitionEvolution, noDeleteTable);

// build new table's predicate
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
Potential NullPointerException when accessing originToNewCols with deleteColRef.

You can modify the code like this:

// fill unselected delete columns
for (Map.Entry<ColumnRefOperator, Column> entry : deleteColumns.entrySet()) {
    ColumnRefOperator deleteColRef = entry.getKey();
    Column deleteCol = entry.getValue();
    if (!colRefToColumnMetaMap.containsKey(deleteColRef)) {
        ColumnRefOperator newColumnRef = originToNewCols.get(deleteColRef);
        if(newColumnRef != null) {
            newColRefToColBuilder.put(newColumnRef, deleteCol);
        }
    }
}

This change ensures that the code checks if originToNewCols.get(deleteColRef) is not null before using it, preventing a potential NullPointerException.

Copy link

Copy link

github-actions bot commented Nov 1, 2024

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Nov 1, 2024

[FE Incremental Coverage Report]

pass : 15 / 15 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/IcebergEqualityDeleteRewriteRule.java 15 15 100.00% []

Copy link

github-actions bot commented Nov 1, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Seaven Seaven merged commit cac2269 into StarRocks:main Nov 1, 2024
58 of 60 checks passed
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants