[Refactor] Chop too large hyperscan regex pattern when logging it on an error #52467

satanson · 2024-10-30T08:51:41Z

Why I'm doing:

When hypercan patten exceeds some threshold(30KB+), hyperscan compilation report error and log the error, the size of be log would grow crazily.

What I'm doing:

Fixes #issue

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
This is a backport pr

Bugfix cherry-pick branch check:

…an error Signed-off-by: satanson <[email protected]>

github-actions · 2024-10-31T04:12:44Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-31T04:12:47Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2024-10-31T04:22:58Z

[BE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/exprs/like_predicate.cpp	3	3	100.00%	[]

kevincai · 2024-10-31T04:32:23Z

be/src/exprs/like_predicate.cpp

-        error << "Invalid hyperscan expression: " << std::string(slice.data, slice.size) << ": "
+        auto chopped_size = std::min<size_t>(slice.size, 64);
+        auto ellipsis = (chopped_size < slice.size) ? "..." : "";
+        error << "Invalid hyperscan expression: " << std::string(slice.data, chopped_size) << ellipsis << ": "


Suggested change

error << "Invalid hyperscan expression: " << std::string(slice.data, chopped_size) << ellipsis << ": "

error << "Invalid hyperscan expression: " << std::string_view(slice.data, chopped_size) << ellipsis << ": "

std::string_view might be lightweight in such case.

it is a low-frequency executing code.

…an error (StarRocks#52467) Signed-off-by: satanson <[email protected]>

satanson · 2024-11-01T02:08:09Z

@Mergifyio backport branch-3.3

mergify · 2024-11-01T02:08:15Z

backport branch-3.3

✅ Backports have been created

#52524 [Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) has been created for branch branch-3.3

satanson · 2024-11-01T02:08:16Z

https://github.com/Mergifyio backport branch-3.2

mergify · 2024-11-01T02:08:20Z

backport branch-3.2

✅ Backports have been created

#52525 [Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) has been created for branch branch-3.2

satanson · 2024-11-01T02:08:24Z

https://github.com/Mergifyio backport branch-3.1

mergify · 2024-11-01T02:08:32Z

backport branch-3.1

✅ Backports have been created

#52526 [Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) has been created for branch branch-3.1

satanson · 2024-11-01T02:08:35Z

https://github.com/Mergifyio backport branch-3.0

…an error (#52467) Signed-off-by: satanson <[email protected]> (cherry picked from commit e95d0be)

satanson · 2024-11-01T02:08:41Z

https://github.com/Mergifyio backport branch-2.5

mergify · 2024-11-01T02:08:42Z

backport branch-3.0

✅ Backports have been created

#52527 [Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) has been created for branch branch-3.0

mergify · 2024-11-01T02:08:47Z

backport branch-2.5

✅ Backports have been created

#52528 [Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) has been created for branch branch-2.5

…an error (#52467) Signed-off-by: satanson <[email protected]> (cherry picked from commit e95d0be)

…an error (backport #52467) (#52526) Co-authored-by: satanson <[email protected]>

…an error (backport #52467) (#52524) Co-authored-by: satanson <[email protected]>

…an error (backport #52467) (#52525) Co-authored-by: satanson <[email protected]>

…an error (backport #52467) (#52528) Co-authored-by: satanson <[email protected]>

…an error (backport #52467) (#52527) Co-authored-by: satanson <[email protected]>

…an error (StarRocks#52467) Signed-off-by: satanson <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>

[Refactor] Chop too large hyperscan regex pattern when logging it on …

1b57458

…an error Signed-off-by: satanson <[email protected]>

satanson requested a review from a team as a code owner October 30, 2024 08:51

mergify bot assigned satanson Oct 30, 2024

stdpain approved these changes Oct 30, 2024

View reviewed changes

kangkaisen approved these changes Oct 30, 2024

View reviewed changes

kevincai reviewed Oct 31, 2024

View reviewed changes

satanson merged commit e95d0be into StarRocks:main Oct 31, 2024
55 checks passed

ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

23752f6

…an error (StarRocks#52467) Signed-off-by: satanson <[email protected]>

mergify bot pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

beb2e87

…an error (#52467) Signed-off-by: satanson <[email protected]> (cherry picked from commit e95d0be)

mergify bot mentioned this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) #52524

Merged

42 tasks

mergify bot pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

d2b0251

…an error (#52467) Signed-off-by: satanson <[email protected]> (cherry picked from commit e95d0be)

mergify bot mentioned this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) #52525

Merged

42 tasks

mergify bot pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

b4808e9

…an error (#52467) Signed-off-by: satanson <[email protected]> (cherry picked from commit e95d0be)

mergify bot mentioned this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) #52526

Merged

42 tasks

mergify bot pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

fddaa9d

…an error (#52467) Signed-off-by: satanson <[email protected]> (cherry picked from commit e95d0be)

mergify bot mentioned this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) #52527

Merged

42 tasks

mergify bot pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

b147da9

…an error (#52467) Signed-off-by: satanson <[email protected]> (cherry picked from commit e95d0be)

mergify bot mentioned this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on an error (backport #52467) #52528

Merged

42 tasks

wanpengfei-git pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

b73aaf4

…an error (backport #52467) (#52526) Co-authored-by: satanson <[email protected]>

github-actions bot added the 3.1-merged label Nov 1, 2024

wanpengfei-git pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

e2ef661

…an error (backport #52467) (#52524) Co-authored-by: satanson <[email protected]>

github-actions bot added the 3.3-merged label Nov 1, 2024

wanpengfei-git pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

00ed1f0

…an error (backport #52467) (#52525) Co-authored-by: satanson <[email protected]>

github-actions bot added the 3.2-merged label Nov 1, 2024

wanpengfei-git pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

2208752

…an error (backport #52467) (#52528) Co-authored-by: satanson <[email protected]>

github-actions bot added the 2.5-merged label Nov 1, 2024

wanpengfei-git pushed a commit that referenced this pull request Nov 1, 2024

[Refactor] Chop too large hyperscan regex pattern when logging it on …

ca6460b

…an error (backport #52467) (#52527) Co-authored-by: satanson <[email protected]>

github-actions bot added the 3.0-merged label Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactor] Chop too large hyperscan regex pattern when logging it on an error #52467

[Refactor] Chop too large hyperscan regex pattern when logging it on an error #52467

satanson commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

kevincai Oct 31, 2024

satanson Oct 31, 2024

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 •

edited

Loading

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 •

edited

Loading

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 •

edited

Loading

satanson commented Nov 1, 2024

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 •

edited

Loading

mergify bot commented Nov 1, 2024 •

edited

Loading

	error << "Invalid hyperscan expression: " << std::string(slice.data, chopped_size) << ellipsis << ": "
	error << "Invalid hyperscan expression: " << std::string_view(slice.data, chopped_size) << ellipsis << ": "

[Refactor] Chop too large hyperscan regex pattern when logging it on an error #52467

[Refactor] Chop too large hyperscan regex pattern when logging it on an error #52467

Conversation

satanson commented Oct 30, 2024

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

github-actions bot commented Oct 31, 2024

[Java-Extensions Incremental Coverage Report]

github-actions bot commented Oct 31, 2024

[FE Incremental Coverage Report]

github-actions bot commented Oct 31, 2024

[BE Incremental Coverage Report]

file detail

kevincai Oct 31, 2024

Choose a reason for hiding this comment

satanson Oct 31, 2024

Choose a reason for hiding this comment

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 • edited Loading

✅ Backports have been created

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 • edited Loading

✅ Backports have been created

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 • edited Loading

✅ Backports have been created

satanson commented Nov 1, 2024

satanson commented Nov 1, 2024

mergify bot commented Nov 1, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Nov 1, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Nov 1, 2024 •

edited

Loading

mergify bot commented Nov 1, 2024 •

edited

Loading

mergify bot commented Nov 1, 2024 •

edited

Loading

mergify bot commented Nov 1, 2024 •

edited

Loading

mergify bot commented Nov 1, 2024 •

edited

Loading