Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add passthrough buffer mem tracker #52404

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[Enhancement] add passthrough buffer mem tracker #52404

merged 1 commit into from
Oct 30, 2024

Conversation

stdpain
Copy link
Contributor

@stdpain stdpain commented Oct 28, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@stdpain stdpain requested review from a team as code owners October 28, 2024 12:02
@stdpain stdpain force-pushed the passthrough_mem_tracker branch from ca79870 to f2afce0 Compare October 29, 2024 02:10
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 7 / 12 (58.33%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/http/default_path_handlers.cpp 0 3 00.00% [152, 153, 154]
🔵 be/src/common/daemon.cpp 0 2 00.00% [165, 166]
🔵 be/src/util/system_metrics.cpp 1 1 100.00% []
🔵 be/src/runtime/exec_env.h 1 1 100.00% []
🔵 be/src/runtime/local_pass_through_buffer.cpp 3 3 100.00% []
🔵 be/src/runtime/exec_env.cpp 1 1 100.00% []
🔵 be/src/script/script.cpp 1 1 100.00% []

@kangkaisen kangkaisen merged commit 008ec47 into StarRocks:main Oct 30, 2024
44 of 45 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 30, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Oct 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 30, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 30, 2024
@stdpain @mergify
[Enhancement] add passthrough buffer mem tracker (#52404)
36b7eb1 
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 008ec47)

# Conflicts:
#	be/src/common/daemon.cpp
#	be/src/runtime/mem_tracker.h
#	be/src/script/script.cpp
@mergify mergify bot mentioned this pull request Oct 30, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
@stdpain @mergify
[Enhancement] add passthrough buffer mem tracker (#52404)
9755271 
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 008ec47)

# Conflicts:
#	be/src/common/daemon.cpp
@mergify mergify bot mentioned this pull request Oct 30, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
@stdpain @mergify
[Enhancement] add passthrough buffer mem tracker (#52404)
c08062e 
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 008ec47)

# Conflicts:
#	be/src/common/daemon.cpp
@mergify mergify bot mentioned this pull request Oct 30, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 30, 2024
@stdpain @mergify
[Enhancement] add passthrough buffer mem tracker (#52404)
432d9d8 
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 008ec47)

# Conflicts:
#	be/src/common/daemon.cpp
#	be/src/runtime/exec_env.cpp
#	be/src/runtime/mem_tracker.h
#	be/src/script/script.cpp
@mergify mergify bot mentioned this pull request Oct 30, 2024
Closed
42 tasks
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
@stdpain @ZiheLiu
[Enhancement] add passthrough buffer mem tracker (StarRocks#52404)
3a7282c 
Signed-off-by: stdpain <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@stdpain @renzhimin7
[Enhancement] add passthrough buffer mem tracker (StarRocks#52404)
6a10a74 
Signed-off-by: stdpain <[email protected]>
Signed-off-by: zhiminr.ren <[email protected]>
stdpain added a commit that referenced this pull request Nov 11, 2024
@stdpain
[Enhancement] add passthrough buffer mem tracker (#52404)
94eb267 
Signed-off-by: stdpain <[email protected]>
(cherry picked from commit 008ec47)

Signed-off-by: stdpain <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Nov 11, 2024
@mergify @stdpain
[Enhancement] add passthrough buffer mem tracker (backport #52404) (#…
052026a 
…52477)

Signed-off-by: stdpain <[email protected]>
Co-authored-by: stdpain <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Nov 15, 2024
@mergify @stdpain
[Enhancement] add passthrough buffer mem tracker (backport #52404) (#…
c8c61b1 
…52476)

Signed-off-by: stdpain <[email protected]>
Co-authored-by: stdpain <[email protected]>
@stdpain stdpain deleted the passthrough_mem_tracker branch December 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@stdpain stdpain

Labels
3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stdpain @kangkaisen @trueeyu