[BugFix] Use a separate thread pool for dictionary collection (backport

#54454) (#54513) Signed-off-by: stdpain <[email protected]> Co-authored-by: stdpain <[email protected]>
StarRocks · Dec 31, 2024 · 8b431fe · 8b431fe
1 parent e77747f
commit 8b431fe
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/fe/fe-core/src/main/java/com/starrocks/common/Config.java b/fe/fe-core/src/main/java/com/starrocks/common/Config.java
@@ -1868,6 +1868,9 @@ public class Config extends ConfigBase {
     @ConfField
     public static long statistic_dict_columns = 100000;
 
+    @ConfField
+    public static int dict_collect_thread_pool_size = 16;
+
     /**
      * The column statistic cache update interval
      */

diff --git a/fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/CacheDictManager.java b/fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/CacheDictManager.java
@@ -24,6 +24,7 @@
 import com.starrocks.common.Config;
 import com.starrocks.common.Pair;
 import com.starrocks.common.Status;
+import com.starrocks.common.ThreadPoolManager;
 import com.starrocks.memory.MemoryTrackable;
 import com.starrocks.qe.ConnectContext;
 import com.starrocks.server.GlobalStateMgr;
@@ -53,7 +54,7 @@ public class CacheDictManager implements IDictManager, MemoryTrackable {
 
     public static final Integer LOW_CARDINALITY_THRESHOLD = 255;
 
-    private CacheDictManager() {
+    public CacheDictManager() {
     }
 
     private static final CacheDictManager INSTANCE = new CacheDictManager();
@@ -106,6 +107,8 @@ public CompletableFuture<Optional<ColumnDict>> asyncReload(
 
     private final AsyncLoadingCache<ColumnIdentifier, Optional<ColumnDict>> dictStatistics = Caffeine.newBuilder()
             .maximumSize(Config.statistic_dict_columns)
+            .executor(ThreadPoolManager.newDaemonCacheThreadPool(Config.dict_collect_thread_pool_size, "cache-dict",
+                    false))
             .buildAsync(dictLoader);
 
     private Optional<ColumnDict> deserializeColumnDict(long tableId, String columnName, TStatisticData statisticData) {