Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hubot-stackstorm to 0.10.3 #150

Closed
wants to merge 2 commits into from
Closed

Update hubot-stackstorm to 0.10.3 #150

wants to merge 2 commits into from

Conversation

blag
Copy link
Contributor

@blag blag commented Apr 22, 2020

Update hubot-stackstorm to version 0.10.3 to pull in StackStorm/hubot-stackstorm#203 which pulled in st2client.js version 1.2.2 from StackStorm/st2client.js#76.

I had to manually add the minimum amount of changes to npm-shrinkwrap.json - we will need to update it fully in #133.

@armab As the release manager for version 3.2, I'll leave this to you to merge.

nmaludy
nmaludy approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Throwing me off with no CHANGELOG

@arm4b arm4b added this to the 3.2.1 milestone Apr 22, 2020
@arm4b
Copy link
Member

arm4b commented Apr 22, 2020 •
edited
Loading

Thanks!

Because adding package-lock.json in StackStorm/st2client.js#77 uncovered a can of worms in dependencies https://github.com/StackStorm/st2client.js/network/alerts and so this PR is not enough to mitigate st2chatops issues, I will postpone this PR to v3.2.1 which will be dedicated to both st2web and st2chatops security dependencies fixes.

@arm4b
Copy link
Member

arm4b commented Apr 22, 2020 •
edited
Loading

@nmaludy I'm also + 💯 if we add the Changelog.
#149 can be done anytime, someone just need to get through the history of at least 1 full release and nicely compose them in a meaningful changelog list as a new PR.

@blag
Copy link
Contributor Author

blag commented Apr 22, 2020

Related: StackStorm/st2client.js#79 - all of them are just devDependencies though, so it won't affect production.

@blag blag closed this Jun 5, 2020
@arm4b arm4b deleted the hubot-st2-version-bump branch June 5, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmaludy nmaludy nmaludy approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@blag @arm4b @nmaludy