Skip to content

Commit

Permalink
Merge pull request #233 from nzlosh/github_actions
Browse files Browse the repository at this point in the history
Use github actions to test nodejs.
  • Loading branch information
nzlosh authored Jan 8, 2024
2 parents e565c50 + d4c8954 commit 333f70d
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 18 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/nodejs.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Node.js CI

on:
push: {}
pull_request:
branches:
- master
workflow_dispatch: {}

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: ["14.x", "16.x", "18.x", "20.x"]

steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm run build --if-present
- run: npm test
16 changes: 0 additions & 16 deletions .travis.yml

This file was deleted.

3 changes: 2 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ Changelog

in development
--------------
* Update ``lodash`` and ``st2client`` dependencies (improvement)
* Use Github Actions for tests.
* Remove TravisCI.

0.12.0
------
Expand Down
3 changes: 2 additions & 1 deletion test/test-st2-invalid-auth.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ describe("invalid st2 credential configuration", function() {
// So instead of using basic string comparison, we use a regex and check for common substrings
// On later node versions then just seeing
// getaddrinfo ENOTFOUND nonexistent-st2-auth-url
expect(err.message).to.match(/getaddrinfo ENOTFOUND nonexistent-st2-auth-url/);
// getaddrinfo EAI_AGAIN nonexistent-st2-auth-url seen on Github Actions.
expect(err.message).to.match(/getaddrinfo (ENOTFOUND|EAI_AGAIN) nonexistent-st2-auth-url/);

done();
});
Expand Down

0 comments on commit 333f70d

Please sign in to comment.