Skip to content

Commit

Permalink
Improve readonly input APCA Lc values for a11y (#1799)
Browse files Browse the repository at this point in the history
* Change readonly input text to black-400 for better contrast

* Add updated visual test images

* Reinstate readonly input test, and fix highcontrast Lc

* Fix linting issue
  • Loading branch information
qheaden-stack authored Aug 12, 2024
1 parent 574295b commit 398e6d2
Show file tree
Hide file tree
Showing 26 changed files with 50 additions and 52 deletions.
2 changes: 0 additions & 2 deletions lib/components/input_textarea/input_textarea.a11y.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ const otherModifiers = ["creditcard", "search"];
},
children,
template,
// TODO revisit these skipped test ids
skippedTestids: [/readonly/],
});
});

Expand Down
4 changes: 2 additions & 2 deletions lib/components/input_textarea/input_textarea.less
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@
&[readonly],
.is-readonly & {
.highcontrast-mode({
--_in-fc: var(--fc-light);
--_in-fc: var(--fc-medium);
});

--_in-bg: var(--black-150);
--_in-bc: var(--bc-light);
--_in-fc: var(--black-300);
--_in-fc: var(--black-400);
}

.validation-states(
Expand Down
4 changes: 2 additions & 2 deletions screenshots/Chromium/baseline/s-input-readonly-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Chromium/baseline/s-input-readonly-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Chromium/baseline/s-textarea-readonly-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Chromium/baseline/s-textarea-readonly-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Firefox/baseline/s-input-readonly-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Firefox/baseline/s-input-readonly-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Firefox/baseline/s-textarea-readonly-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Firefox/baseline/s-textarea-readonly-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Webkit/baseline/s-input-readonly-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Webkit/baseline/s-input-readonly-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Webkit/baseline/s-textarea-readonly-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions screenshots/Webkit/baseline/s-textarea-readonly-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 398e6d2

Please sign in to comment.