Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Update publish-with-slsa.yml #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Bug-Fixer1
Copy link

I'm working on your bounty this is the PR

I'm working on your bounty this is the PR
@Bug-Fixer1 Bug-Fixer1 requested a review from St0rmz1 as a code owner April 19, 2024 20:02
with:
image: index.docker.io/st0rmz1/replicated-sdk:v${{needs.get-tags.outputs.tag}}
digest: ${{ needs.package-and-publish.outputs.image_digest_apko }}
registry-username: ${{ secrets.DOCKERHUB_USER }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid syntax. the user and password entries need to be under 'secrets'.

# digest:
with:
image: index.docker.io/st0rmz1/replicated-sdk:v${{needs.get-tags.outputs.tag}}
digest: ${{ needs.package-and-publish.outputs.image_digest_apko }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work. If you run and test the workflow, you will find the digest value is blank.
Please test changes prior to submitting a PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok my bad i'll try to solve this

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that Github thinks its a secret and is prohibiting it to be used as an output

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants