This repository has been archived by the owner on Sep 27, 2020. It is now read-only.
拆分TCP和shadowsocks #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rc452860
commented
Jul 8, 2018
| @@ -85,7 +85,7 @@ export default class ShadowsocksFormatter { | |||
| } | |||
|
|
|||
| for (let i = 0; i < ipBuffer.length; i++) { | |||
| buffer[i + (header.version === ShadowsocksHeaderVersion.Domain ? 2 : 1)] = ipBuffer[i]; | |||
There was a problem hiding this comment.
这个地方您在79行已经把Domain Length算在了ipBuffer里边。所以这里又多加了1
|
谢谢 我会在review后合并 |
|
我想请问下我注意到 |
|
我提交的时候他并没有提示我这个文件有改变。我用BC对比发现这个文件好像是一致的。 |
|
|
|
好吧 因为我也不是很清楚驱动安装的细节 所以还需要请教你 |
|
好像您添加功能时候没有遵循TSLint当RP合并以后我会做相应修改以便遵守TSLint. |
Srar
reviewed
Jul 9, 2018
| @@ -271,13 +293,15 @@ async function main() { | |||
|
|
|||
| // tslint:disable-next-line:ban-types | |||
| const filters: Array<Function> = []; | |||
| filters.push(require("./filters/TCP").default); | |||
| filters.push(require("./tunnel/ShadowsocksTunnel").default); | |||
There was a problem hiding this comment.
是否可以改成实现interface来作为可变代理类型呢, 如果以后加很多代理类型的话 这样方式会不好判断.
|
好吧，非常抱歉，第一次写typescript，以前没写过这个。js也写的很少。下次提交我尽量按照规范来。我这边正在实现ssh的dynamic port forward。我写完看一下能不能提炼公共的逻辑出来当接口。 |
|
我最近可能没时间处理pr请谅解（ 等有时间后会尽量把pr看好合并 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要提交：拆分TCP和Shadowsocks协议。
附带：driver驱动替换为sstap已签名版本、默认不开启udp多倍发包避免在未安装wincap电脑上报错（照顾小白）、添加启动时ping代理服务器