Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll down when new message even if window is inactive #399

Merged
merged 5 commits into from
Dec 3, 2023
Merged

Scroll down when new message even if window is inactive #399

merged 5 commits into from
Dec 3, 2023

Conversation

MatusGuy
Copy link
Contributor

fixes #382

if you don't like this, then can it at least be optional? I think this functionality is vital to an irc client.

@SilverRainZ
Copy link
Member

I prefer to make it optional, can you please add a new item to SuiApplicationConfig and update the builtin config file(data/builtin.cfg)?

@MatusGuy
Copy link
Contributor Author

@SilverRainZ Done. Sorry for taking long.

SilverRainZ
SilverRainZ approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@SilverRainZ SilverRainZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SilverRainZ SilverRainZ added this to the 1.6 milestone Dec 3, 2023
@SilverRainZ SilverRainZ merged commit 2d3c15c into SrainApp:master Dec 3, 2023
2 checks passed
@MatusGuy MatusGuy deleted the autoscroll branch December 3, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilverRainZ SilverRainZ SilverRainZ approved these changes

Assignees
No one assigned
Labels
mod-config mod-ui
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

no auto-scrolling nor hint that new messages arrived below viewport
2 participants
@MatusGuy @SilverRainZ