Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final fixes and crate/package version bumps #71

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Final fixes and crate/package version bumps #71

merged 3 commits into from
Jan 5, 2024

Conversation

vovacodes
Copy link
Contributor

@vovacodes vovacodes commented Jan 4, 2024 •
edited
Loading

@vovacodes
feat(remove_member): remove threshold auto-update after member removal
246685f 
This commit removes the automatic threshold update logic when a member removal would result in a state where the remaining voting members number is insufficient to reach threshold. This used to implicitly reduce the threshold down to the remaining number of voting members. Now, configuration changes require explicit threshold changes to avoid the  side-effect unexpected by some users. Test cases have been added to cover these cases as well.
@vovacodes
refactor(spending_limit_use,config_transaction_execute): remove unnec…
ad79932 
…essary `mut` attributes from accounts
@vovacodes
refactor(multisig_create): remove rentCollector argument
0230cec 
This commit reverts the multisig_create interface to the one that's currently deployed to prod. We do this to ensure the old versions of our SDK continue working the same way after we deploy the Rent Reclamation and Global Config features to prod. For creating multisigs with rent_collector set, we provide 2 alternatives: `multisig_create_v2` or `multisig_set_rent_collector`
ogmedia
ogmedia approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ogmedia ogmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@vovacodes vovacodes merged commit 7f0696f into main Jan 5, 2024
2 checks passed
@vovacodes vovacodes deleted the feat/post-audit-adjustments branch January 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogmedia ogmedia ogmedia approved these changes

@bguillaumat bguillaumat Awaiting requested review from bguillaumat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vovacodes @ogmedia