Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rs-sdk): remove deprecated multisig_create #139

Merged

Conversation

joeysqds
Copy link

Since multisig_create has officially been removed in favor of multisig_create_v2, it needs to be removed from the SDK to fix build issues

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-sdk-typedoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 8:03pm

Copy link
Contributor

@0xRigel-squads 0xRigel-squads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the versioning issue it looks good 👍

sdk/rs/Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@0xRigel-squads 0xRigel-squads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@sqds-rohan sqds-rohan self-requested a review December 2, 2024 13:30
Copy link

@sqds-rohan sqds-rohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@joeymeere joeymeere force-pushed the fix/rs-sdk-deprec-ix-reference branch from 53e90c4 to 2db314f Compare December 4, 2024 20:02
@joeymeere joeymeere merged commit b2b28b7 into Squads-Protocol:main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants