Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #70, working in progress.
Steps
kv::Key
andkv::Value
value-bag
directly (alias) for value first.kvs
field tostruct Record
.kv
optional parameter.kv
is optional, just like the existinglogger
argument, and I may wish to allow them to be in any order. The colon allows us to distinguish with the formatting arguments so that it can be placed anywhere.FullFormatter
.PatternFormatter
.{kv}
pattern to output like"{ k1=1, k2=text }"
kv
field inJsonFormatter
.phf
map for KV. (self-reminder: benchmarking it..)Record
, downcasting, etc.).