Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide for cross compiling using docker #1304

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

mietzen
Copy link
Contributor

@mietzen mietzen commented Sep 26, 2024

Added a guide for cross compiling using docker for e.g. building arm64 as described in #1053

Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, thanks!

Since this is a new file in the docs folder, a link in SUMMARY.md would have to be added.

You can also check, if everything looks good by building the docs with mdbook.

@mietzen
Copy link
Contributor Author

mietzen commented Oct 17, 2024

I added the file to SUMMARY.md and tested it with mdbook, everything looked good 👍

Copy link
Member

@eladyn eladyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you.

@eladyn eladyn merged commit 690ab7e into Spotifyd:master Oct 17, 2024
@mietzen
Copy link
Contributor Author

mietzen commented Oct 18, 2024

@eladyn I had a look at your CD Pipeline. It could be simplified using this approach. Would you be open / interested to accept a PR for your CI/CD Pipelines?

@eladyn
Copy link
Member

eladyn commented Oct 18, 2024

Yes, absolutely! I was thinking that too, but currently our pipeline is really terrible, so I didn't want to put that burden on you. 😅 But if you're motivated that would be great!

@mietzen mietzen deleted the patch-1 branch October 18, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants