Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shadow under forked plugin id #146

Merged
merged 3 commits into from
May 7, 2024

Conversation

jpenilla
Copy link
Contributor

@jpenilla jpenilla commented May 7, 2024

fixes #145

I also considered checking for the existence of the ShadowPlugin class instead, however it wouldn't work due to the classloader isolation we already work around.

fixes SpongePowered#145

I also considered checking for the existence of the ShadowPlugin class instead, however it wouldn't work due to the classloader isolation we already work around.
@zml2008 zml2008 self-assigned this May 7, 2024
@zml2008
Copy link
Member

zml2008 commented May 7, 2024

thank you!

@zml2008 zml2008 added this pull request to the merge queue May 7, 2024
Merged via the queue into SpongePowered:master with commit 0cfde2e May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadow with io.github.goooler.shadow is broken
2 participants