-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated BungeeCord docs #682
Conversation
8295e0d
to
b658e3c
Compare
|
||
Using BungeeCord with IP Forwarding | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
If you wish to use IP Forwarding: | ||
|
||
* In the BungeeCord ``config.yml``, set ``ip_forward`` to ``true`` | ||
* In Sponge's config (config/sponge/global.conf), set ``modules.bungeecord`` to ``true`` and ``bungeecord.ip-forwarding`` to | ||
* In Sponge's config (``config/sponge/global.conf``), set ``modules.bungeecord`` to ``true`` and ``bungeecord.ip-forwarding`` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please limit the line length to 120 characters. (split before bungeecord.ip-forwarding
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was already above 120 qq
``true`` | ||
* If you have any other server software, consult the documentation for that server. | ||
|
||
This must be done for **all** servers that are connected to the BungeeCord network. Then, just follow the instructions | ||
for using BungeeCord without IP Forwarding. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate empty line
``config.yml`` file. Bungee will then forward any connections to the server when required. It is a good precaution to | ||
set the ``server-port`` to something other than ``25565``. | ||
For SpongeVanilla or Vanilla clients connecting to unmodded SpongeForge, IP Forwarding works out of the box. | ||
`Pull <https://github.com/SpigotMC/BungeeCord/pull/1557>`_ `requests <https://github.com/SpigotMC/BungeeCord/pull/1678>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go for Pull requests: #1557 and #1678
so you actually see that there are more than one PRs releated to that, (but thats optional IMO)
Also watch the line length ( 121 > 120 ;-) ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the numbers mean nothing to readers, and you can see it's two links as the blue line of a link does not include the space between
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot test the technical details of this, but otherwise it looks good to me.
Why does Travis CI not try to build this PR? It works (at least locally for me). |
@phit was caught stealing cookies from their cookie jar. 🍪 |
I don't think SpongePls is maintained any more and does not support negative packet IDs that some mods like to use. I think we should just be suggesting Waterfall for simplicity (other forks are available). Otherwise, I have no interest in chasing up the Bungee PRs any further so I agree with the removal of those statements. |
Waterfall has issues with mods too, which come from upstream.. both of which I had to "fix" for my server 1 2 |
Using BungeeCord without IP Forwarding | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
While it is recommended that you use IP Forwarding wherever possible. If you do not wish to do so, simply ensure that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken clause. Delete the While.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even write this, but done..
As it has been years at this point and the PR's have no progress, I'd rather link to an actual solution to people, tired of having to link people a solution when it could just be in the Docs.
As it has been years at this point and the PR's have no progress,
I'd rather link to an actual solution to people, tired of having to link
people a solution when it could just be in the Docs.
Also moved without IP Forwarding to the end as nobody should be really using that, and with is more important.