Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BungeeCord docs #682

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Conversation

phit
Copy link
Contributor

@phit phit commented Apr 15, 2018

As it has been years at this point and the PR's have no progress,
I'd rather link to an actual solution to people, tired of having to link
people a solution when it could just be in the Docs.

Also moved without IP Forwarding to the end as nobody should be really using that, and with is more important.

@phit phit added the needs review The submission is ready and needs to be reviewed label Apr 15, 2018
@Inscrutable Inscrutable added the input wanted We would like to hear your opinion label Apr 15, 2018
@phit phit force-pushed the bungeecord branch 2 times, most recently from 8295e0d to b658e3c Compare April 15, 2018 15:12

Using BungeeCord with IP Forwarding
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If you wish to use IP Forwarding:

* In the BungeeCord ``config.yml``, set ``ip_forward`` to ``true``
* In Sponge's config (config/sponge/global.conf), set ``modules.bungeecord`` to ``true`` and ``bungeecord.ip-forwarding`` to
* In Sponge's config (``config/sponge/global.conf``), set ``modules.bungeecord`` to ``true`` and ``bungeecord.ip-forwarding`` to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit the line length to 120 characters. (split before bungeecord.ip-forwarding)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was already above 120 qq

``true``
* If you have any other server software, consult the documentation for that server.

This must be done for **all** servers that are connected to the BungeeCord network. Then, just follow the instructions
for using BungeeCord without IP Forwarding.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate empty line

``config.yml`` file. Bungee will then forward any connections to the server when required. It is a good precaution to
set the ``server-port`` to something other than ``25565``.
For SpongeVanilla or Vanilla clients connecting to unmodded SpongeForge, IP Forwarding works out of the box.
`Pull <https://github.com/SpigotMC/BungeeCord/pull/1557>`_ `requests <https://github.com/SpigotMC/BungeeCord/pull/1678>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go for Pull requests: #1557 and #1678 so you actually see that there are more than one PRs releated to that, (but thats optional IMO)
Also watch the line length ( 121 > 120 ;-) ).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the numbers mean nothing to readers, and you can see it's two links as the blue line of a link does not include the space between

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test the technical details of this, but otherwise it looks good to me.

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2018

Why does Travis CI not try to build this PR? It works (at least locally for me).

@vectrixdevelops
Copy link

@ST-DDT It's apparently listed as Abuse on Travis, @phit is going to try contact their support to clear that up.

@phit phit closed this Apr 16, 2018
@phit phit reopened this Apr 16, 2018
@kashike
Copy link
Contributor

kashike commented Apr 17, 2018

@phit was caught stealing cookies from their cookie jar. 🍪

@dualspiral
Copy link
Contributor

I don't think SpongePls is maintained any more and does not support negative packet IDs that some mods like to use. I think we should just be suggesting Waterfall for simplicity (other forks are available).

Otherwise, I have no interest in chasing up the Bungee PRs any further so I agree with the removal of those statements.

@phit
Copy link
Contributor Author

phit commented Apr 17, 2018

Waterfall has issues with mods too, which come from upstream..
PaperMC/Waterfall#136
HexagonMC/BungeeCord#148
PaperMC/Waterfall#216

both of which I had to "fix" for my server 1 2
so really it doesn't matter, both options have issues

Using BungeeCord without IP Forwarding
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

While it is recommended that you use IP Forwarding wherever possible. If you do not wish to do so, simply ensure that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken clause. Delete the While.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even write this, but done..

@Inscrutable Inscrutable removed input wanted We would like to hear your opinion needs review The submission is ready and needs to be reviewed labels Apr 19, 2018
As it has been years at this point and the PR's have no progress,
I'd rather link to an actual solution to people, tired of having to link
people a solution when it could just be in the Docs.
@Inscrutable Inscrutable merged commit e1735c7 into SpongePowered:stable Apr 20, 2018
@phit phit deleted the bungeecord branch April 20, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants