Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build issues #1013

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fixed build issues #1013

merged 2 commits into from
Oct 17, 2024

Conversation

mosemister
Copy link
Member

No description provided.

@mosemister mosemister marked this pull request as draft August 19, 2024 20:11
@mosemister mosemister added the needs review The submission is ready and needs to be reviewed label Aug 19, 2024
@mosemister mosemister marked this pull request as ready for review August 19, 2024 21:55
@ST-DDT
Copy link
Member

ST-DDT commented Oct 12, 2024

I still get an error:

[13:32:16] Using gulpfile ~\git\Minecraft\Sponge\SpongeDocs\gulpfile.js
[13:32:16] Starting 'default'...
[13:32:16] Starting 'build:dev'...
[13:32:16] Starting 'clean'...
[13:32:16] Finished 'clean' after 8.35 ms
[13:32:16] Starting 'sphinx:dev'...
[13:32:16] 'sphinx:dev' errored after 5.51 ms
[13:32:16] Error in plugin "sphinx"
Message:
    spawn sphinx-build ENOENT
Details:
    errno: -4058
    code: ENOENT
    syscall: spawn sphinx-build
    path: sphinx-build
    spawnargs: source,build/dev/html

[13:32:16] 'build:dev' errored after 18 ms
[13:32:16] 'default' errored after 21 ms

Any idea on how to debug it?

@mosemister
Copy link
Member Author

Interesting. Ill take a look when i get some time :) hopefully it's just a simple fix i forgot to document

@mosemister
Copy link
Member Author

I still get an error:

[13:32:16] Using gulpfile ~\git\Minecraft\Sponge\SpongeDocs\gulpfile.js
[13:32:16] Starting 'default'...
[13:32:16] Starting 'build:dev'...
[13:32:16] Starting 'clean'...
[13:32:16] Finished 'clean' after 8.35 ms
[13:32:16] Starting 'sphinx:dev'...
[13:32:16] 'sphinx:dev' errored after 5.51 ms
[13:32:16] Error in plugin "sphinx"
Message:
    spawn sphinx-build ENOENT
Details:
    errno: -4058
    code: ENOENT
    syscall: spawn sphinx-build
    path: sphinx-build
    spawnargs: source,build/dev/html

[13:32:16] 'build:dev' errored after 18 ms
[13:32:16] 'default' errored after 21 ms

Any idea on how to debug it?

Just installed this branch on a fresh PC with no issues. Can I make sure the following?

  • Your on this branch?
  • You have followed the install steps

npm install -g gulp
npm install
pip install -r requirements.txt
gulp

(the pip install being the part that has changed)

I saw on discord you were having git issues on discord, I tested with the latest git version (git version 2.47.0.windows.1) without any issues. Unsure whats going wrong there nor how to debug it

@ST-DDT
Copy link
Member

ST-DDT commented Oct 17, 2024

I got it working.
It might have been a strange combination of requiring admin permissions and imghdr getting removed in Python 3.13.

It works with python 3.12 when using elevated permissions.

@mosemister mosemister merged commit f1adb48 into stable Oct 17, 2024
6 checks passed
@mosemister mosemister deleted the bug/build-fix branch October 17, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The submission is ready and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants