Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Start on Docker Integration #347

Open
wants to merge 16 commits into
base: staging
Choose a base branch
from
Open

Conversation

phase
Copy link
Contributor

@phase phase commented Jan 7, 2018

SpongeAuth fails to connect to the DB currently but we're getting
there.

SpongeAuth fails to connect to the DB currently but we're getting
there.

Signed-off-by: Jadon Fowler <[email protected]>
@phase phase changed the title Start on Docker Integration WIP: Start on Docker Integration Jan 7, 2018
Dockerfile Show resolved Hide resolved
@@ -155,9 +155,9 @@ slick.dbs.default {
driver = "org.postgresql.Driver"
url = "jdbc:postgresql://localhost/ore"
url = ${?JDBC_DATABASE_URL}
user = "root"
user = "spongeauth"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave the defaults, i don't know what this will break. the docker container & local users should set this however they want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Ore's connection to the database, it shouldn't use the same credentials as the spongeauth connection

@progwml6
Copy link
Member

progwml6 commented Jan 9, 2018

a build script should be writtten for this that adds the needed variables for statusz like so, https://github.com/SpongePowered/Ore/blob/1.0.0/.deploy/build.sh#L40

https://github.com/SpongePowered/Ore/blob/1.0.0/.deploy/docker/Dockerfile#L9-L18 need to be added as well for that page to work.

@progwml6
Copy link
Member

progwml6 commented Jan 9, 2018

Additionally, there are a number of readme additions and other needed things in the docker-compose.yaml #330 that need to be in here

@ryantheleach ryantheleach added this to the v1.6.0 milestone Jan 16, 2018
@phase
Copy link
Contributor Author

phase commented Mar 6, 2018

Important commands for working with Docker & Compose:

docker build . -t ore_app
docker-compose up

@phase phase self-assigned this Mar 6, 2018
Signed-off-by: Jadon Fowler <[email protected]>
@lukegb lukegb self-requested a review March 6, 2018 03:20
@progwml6 progwml6 self-requested a review March 6, 2018 19:25
@phase phase modified the milestones: v1.6.0, v1.7.0 Jul 14, 2018
@phase
Copy link
Contributor Author

phase commented Aug 29, 2018

phase#1

@Katrix Katrix changed the base branch from master to staging June 26, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants