-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Start on Docker Integration #347
base: staging
Are you sure you want to change the base?
Conversation
SpongeAuth fails to connect to the DB currently but we're getting there. Signed-off-by: Jadon Fowler <[email protected]>
conf/application.conf.template
Outdated
@@ -155,9 +155,9 @@ slick.dbs.default { | |||
driver = "org.postgresql.Driver" | |||
url = "jdbc:postgresql://localhost/ore" | |||
url = ${?JDBC_DATABASE_URL} | |||
user = "root" | |||
user = "spongeauth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave the defaults, i don't know what this will break. the docker container & local users should set this however they want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is Ore's connection to the database, it shouldn't use the same credentials as the spongeauth connection
a build script should be writtten for this that adds the needed variables for statusz like so, https://github.com/SpongePowered/Ore/blob/1.0.0/.deploy/build.sh#L40 https://github.com/SpongePowered/Ore/blob/1.0.0/.deploy/docker/Dockerfile#L9-L18 need to be added as well for that page to work. |
Additionally, there are a number of readme additions and other needed things in the docker-compose.yaml #330 that need to be in here |
Signed-off-by: Jadon Fowler <[email protected]>
Important commands for working with Docker & Compose:
|
Signed-off-by: Jadon Fowler <[email protected]>
Signed-off-by: Jadon Fowler <[email protected]>
Ore container may have to be manually configured for some stuff
Docker Notification Source
Signed-off-by: Jadon Fowler <[email protected]>
Signed-off-by: Jadon Fowler <[email protected]>
SpongeAuth fails to connect to the DB currently but we're getting
there.