Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 17of20: ClockDomain.py: compute self.frequency for __str__ (MED) #28

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
e56bd5a
AhbLite3.py: assignment <= is deprecated
dlmiles May 15, 2023
bf4b5c2
Apb3.py: assignment <= is deprecated
dlmiles May 15, 2023
e622628
Axi4.py: assignment <= is deprecated
dlmiles May 15, 2023
94f7f62
ClockDomain.py: assignment <= is deprecated
dlmiles May 15, 2023
be01610
Spi.py: assignment <= is deprecated
dlmiles May 15, 2023
16fc943
Stream.py: assignment <= is deprecated
dlmiles May 15, 2023
bfb831d
misc.py: assignment <= is deprecated
dlmiles May 15, 2023
d28bc43
AhbLite3.py: import local ref change
dlmiles May 15, 2023
f13c70a
Apb3.py: import local ref change
dlmiles May 15, 2023
72cf466
Axi4.py: import local ref change
dlmiles May 15, 2023
17baf5e
Flow.py: import local ref change
dlmiles May 15, 2023
450f855
Scorboard.py: import local ref change
dlmiles May 15, 2023
2afed89
Spi.py: import local ref change
dlmiles May 15, 2023
1373392
Stream.py: import local ref change
dlmiles May 15, 2023
38393a7
AhbLite3.py: cocotb.fork is deprecated
dlmiles May 15, 2023
2dae019
ClockDomain.py: cocotb.fork is deprecated
dlmiles May 15, 2023
c74e92f
Flow.py: cocotb.fork is deprecated
dlmiles May 15, 2023
4a2ced2
Stream.py: cocotb.fork is deprecated
dlmiles May 15, 2023
f7248f0
AhbLite3.py: consistently use @coroutine
dlmiles May 15, 2023
6ea4610
Apb3.py: consistently use @coroutine
dlmiles May 15, 2023
9800fd5
ClockDomain.py: consistently use @coroutine
dlmiles May 15, 2023
f6bd5e9
Flow.py: consistently use @coroutine
dlmiles May 15, 2023
102db6f
Phase.py: consistently use @coroutine
dlmiles May 15, 2023
13927f9
Spi.py: consistently use @coroutine
dlmiles May 15, 2023
7297265
Stream.py: consistently use @coroutine
dlmiles May 15, 2023
25ddfc3
misc.py: consistently use @coroutine
dlmiles May 15, 2023
0a283f0
AhbLite3.py: dut.log is deprecated
dlmiles May 15, 2023
4c47bad
Scorboard.py: dut.log is deprecated
dlmiles May 15, 2023
3b92a7d
AhbLite3.py: Whitespace change only
dlmiles May 15, 2023
1749517
Apb3.py: Whitespace change only
dlmiles May 15, 2023
1ae8205
Axi4.py: Whitespace change only
dlmiles May 15, 2023
29ef28e
ClockDomain.py: Whitespace change only
dlmiles May 15, 2023
2b5392a
Flow.py: Whitespace change only
dlmiles May 15, 2023
cea05b3
Phase.py: Whitespace change only
dlmiles May 15, 2023
0beca2b
Scorboard.py: Whitespace change only
dlmiles May 15, 2023
5c28060
Spi.py: Whitespace change only
dlmiles May 15, 2023
899580f
Stream.py: Whitespace change only
dlmiles May 15, 2023
39eb195
TriState.py: Whitespace change only
dlmiles May 15, 2023
92187c7
misc.py: Whitespace change only
dlmiles May 15, 2023
ba836ea
AhbLite3.py: Whitespace change only (2nd)
dlmiles May 15, 2023
8f38841
Apb3.py: Whitespace change only (2nd)
dlmiles May 15, 2023
21cd582
ClockDomain.py: Whitespace change only (2nd)
dlmiles May 15, 2023
9ec680f
Flow.py: Whitespace change only (2nd)
dlmiles May 15, 2023
395b015
ClockDomain.py: equality operator with object None
dlmiles May 15, 2023
0ef489f
Phase.py: equality operator with object None
dlmiles May 15, 2023
b9b12e9
Stream.py: equality operator with object None
dlmiles May 15, 2023
4edbbd0
ClockDomain.py: stray trailing semicolon
dlmiles May 15, 2023
9f8c616
Apb3.py: equality operator with True|False
dlmiles May 15, 2023
cdf8ad5
Stream.py: equality operator with True|False
dlmiles May 15, 2023
2ec3e91
misc.py equality operator with True|False
dlmiles May 15, 2023
26ccddc
Axi4.py: use of built-in as local variable len|min|max
dlmiles May 15, 2023
400c1cd
misc.py: use of built-in as local variable len|min|max
dlmiles May 15, 2023
9283fcf
misc.py: Move import declaration to top of file
dlmiles May 15, 2023
0d4ed52
AhbLite3.py: black --line-length 136 changes
dlmiles May 15, 2023
b73ee46
Axi4.py: black --line-length 136 changes
dlmiles May 15, 2023
42bd641
Spi.py: black --line-length 136 changes
dlmiles May 15, 2023
c15b9b3
Stream.py: black --line-length 136 changes
dlmiles May 15, 2023
05b83e0
misc.py: black --line-length 136 changes
dlmiles May 15, 2023
6ed3bb4
Apb3.py: flake8 --max-line-length 136 changes
dlmiles May 15, 2023
4ad063a
Phase.py: flake8 --max-line-length 136 changes
dlmiles May 15, 2023
d599f54
Scorboard.py: flake8 --max-line-length 136 changes
dlmiles May 15, 2023
b57de3a
Spi.py: flake8 --max-line-length 136 changes
dlmiles May 15, 2023
a095244
misc.py: flake8 --max-line-length 136 changes
dlmiles May 15, 2023
ef11769
Stream.py: nextDelay never assigned initial value
dlmiles May 15, 2023
f2e316b
Stream.py: local variable 'e' is assigned to but never used
dlmiles May 15, 2023
5508e4e
AhbLite3.py: flake8 --max-line-length 136 code-changes
dlmiles May 15, 2023
ce1b7d0
Phase.py: flake8 --max-line-length 136 code-changes
dlmiles May 15, 2023
328df3f
.github/workflows/lint.yml: added file
dlmiles May 15, 2023
5397af9
ClockDomain.py: compute self.frequency for __str__
dlmiles May 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ClockDomain.py: cocotb.fork is deprecated
dlmiles committed May 15, 2023
commit 2dae0197265959f8093abffe87f9d77b7e290ddb
6 changes: 3 additions & 3 deletions ClockDomain.py
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ class RESET_ACTIVE_LEVEL:
#
# # Create a clock with a reset active high
# clockDomain = ClockDomain(dut.clk, 400, dut.reset, RESET_ACTIVE_LEVEL.HIGH)
# cocobt.fork( clockDomain.start() )
# cocotb.start_soon( clockDomain.start() )
#
class ClockDomain:

@@ -45,9 +45,9 @@ def __init__(self, clk, halfPeriod, reset=None, resetActiveLevel=RESET_ACTIVE_LE
@cocotb.coroutine
def start(self):

self.fork_gen = cocotb.fork(self._clkGen())
self.fork_gen = cocotb.start_soon(self._clkGen())
if self.reset != None :
cocotb.fork(self._waitEndReset())
cocotb.start_soon(self._waitEndReset())

if self.reset:
self.reset.value = self.typeReset