Allow different partitions #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-B
reviewed
Oct 7, 2024
Christian-B
reviewed
Oct 7, 2024
spynnaker_integration_tests/test_various/test_send_multiple_partitions.py
Outdated
Show resolved
Hide resolved
Christian-B
reviewed
Oct 7, 2024
spynnaker_integration_tests/test_various/test_send_multiple_partitions.py
Outdated
Show resolved
Hide resolved
Christian-B
reviewed
Oct 7, 2024
spynnaker_integration_tests/test_various/test_send_multiple_partitions.py
Outdated
Show resolved
Hide resolved
Christian-B
reviewed
Oct 14, 2024
| @@ -198,7 +200,7 @@ static inline void process_weight_update( | |||
| const uint32_t *words = (uint32_t *) synapse_row_plastic_controls(fixed_region); | |||
| uint32_t pre_spike = plastic_region_address->pre_spike; | |||
|
|
|||
| log_debug("Weight change update for pre-neuron %u", pre_spike); | |||
| log_info("Weight change update for pre-neuron %u", pre_spike); | |||
There was a problem hiding this comment.
Do we need this (and others) to stay at info level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow different partitions from the default SPIKE_PARTITION_ID to be used. By default this on is used if not specified, and some models will only send with that partition id still, but this allows the reception of different partition ids at least, which makes it easier to integrate with other sending models.
Tested with SpiNNakerManchester/IntegrationTests#294 (failing only for unrelated reasons)