Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recording data fixes #1189

Merged
merged 6 commits into from
Sep 11, 2024
Merged

recording data fixes #1189

merged 6 commits into from
Sep 11, 2024

Conversation

Christian-B
Copy link
Member

part of SpiNNakerManchester/SpiNNFrontEndCommon#1209

The decision of which placements to record based on last/only loop vs middle auto pause loop is handled by Python.

The main changes here are for the creation of the record row in the data based on if the region is_recording or not

  • appendRecordingContents renamed extractRecordingContents as the method handles both regions that append (is_recording) and the ones that record the new region state.
  • isRecording param added to Region class and methods that create a region for both is_recording and not
  • isRecording added to database replacing unused columns (identical to python changes)
  • SQL and calling method adapted for isRecording
  • getRegion renamed getRecordingRegion to reflect it should only be called when isRecording is True

@rowleya rowleya added this pull request to the merge queue Sep 11, 2024
Merged via the queue into master with commit acf3713 Sep 11, 2024
9 checks passed
@rowleya rowleya deleted the rd2 branch September 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants