feat(format): extend native Intl options #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementParis016
force-pushed
the
feat/format-extend-intl-options
branch
from
956893d to
d455a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make the formatting options of
format()andunsafeFormat()extend from the nativeIntl.NumberFormatoptions and spread them so the consumer can use any of the native options, especially the ones that have been added in the spec recently (such asnotationandcompactDisplay), without requiring the library to be updated.But I'm actually not sure this could work 🤔
I don't know if the
Intl.NumberFormattype is bundled in with the library and in which version (for ex.es5doesn't have the same type thanes2020).Anyway, there is an issue with tests and I can't figure it out. It seems we pre-build the calls to
Intl.NumberFormatand this somehow makes this fail now. Any help would be much appreciated 🙏🏻