New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK-408] 메모, 멘토 관련 엔티티 생성 #14

Merged

beautiflow merged 33 commits into develop from feature/task-408-create_entity

Apr 30, 2024

Collaborator

beautiflow commented Apr 25, 2024 •

edited

Loading

Description

메모 엔티티 생성
멘토 엔티티 생성
멘토 경력사항 엔티티 생성
경력 링크 엔티티 생성
멘토링 가능날짜 엔티티 생성

정적 팩토리 메소드 패턴으로 변경
회원 엔티티 생성
멘토링 신청서 엔티티 생성
멘토링 리뷰 엔티티 생성

enum 클래스 생성 - MentorCareerPeriod, MentorGenre, MentoringApplyStatus, MentoringPossibleDateDay, MentorStatus
enum 클래스 생성으로 인한 타입 수정
식별자 값 자동 생성부분 제거

이넘 클래스 필드 한글명으로 변경
CareerLink → MentorHistory 변경 및 필드 추가
필드명 간략하게 수정
정적 팩토리 메서드 네이밍 규칙 of 적용
멘토_멘토링_장르 엔티티 생성
멘토링_장르 이름 수정

refactor: Member 관련 파일 주석 처리 및 이름 변경(User -> Member)으로 인한 삭제
refactor: Member 타입 수정으로 인한 User 타입 파일 주석 및 삭제
refactor: User -> Member 타입 변경 및 관련 필드 수정
refactor: MemoEntity - YoutubeVideo import 주소 수정

결과

More

리뷰테이블 PK 가 멘토링신청서 PK 와 식별관계로 지정했었는데 JPA 관련부분 확인부탁드립니다.

제 로컬 db에 있는 youtube_video 테이블은 머지 후 반영된걸로 변경예정입니다.

beautiflow added 5 commits

April 25, 2024 17:24


          feat: create Mento Entity

9466dac


          feat: create MentoCareer Entity

853d367


          feat: create CareerLink Entity

f96e7e2


          feat: create Memo Entity

deb0be6


          feat: create MentoringPossibleDate Entity

8c8658a

beautiflow added the ✨ Feature label

beautiflow requested review from Kim-AYoung and blacklabf

April 25, 2024 08:44

beautiflow self-assigned this

github-actions bot commented Apr 25, 2024 •

edited

Loading

Test Results

1 tests 1 ✅ 0s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 9a1f825.

♻️ This comment has been updated with latest results.


          feat: modified MentoringPossibleDate Entity

ad24067

beautiflow changed the title ~~[TASK-408] Create entity~~ [TASK-408] 메모, 멘토 관련 엔티티 생성

blacklabf reviewed

View reviewed changes

src/main/java/com/speechpeach/speech/memo/entity/Memo.java Outdated Show resolved Hide resolved

blacklabf reviewed

View reviewed changes

src/main/java/com/speechpeach/speech/memo/entity/Memo.java Outdated Show resolved Hide resolved

blacklabf reviewed

View reviewed changes

src/main/java/com/speechpeach/speech/mento/entity/CareerLink.java Outdated Show resolved Hide resolved

blacklabf reviewed

View reviewed changes

src/main/java/com/speechpeach/speech/memo/entity/Memo.java Outdated Show resolved Hide resolved

blacklabf reviewed

View reviewed changes

src/main/java/com/speechpeach/speech/mento/entity/CareerLink.java Outdated Show resolved Hide resolved

blacklabf reviewed

View reviewed changes

src/main/java/com/speechpeach/speech/memo/entity/Memo.java Outdated Show resolved Hide resolved

blacklabf reviewed

View reviewed changes

src/main/java/com/speechpeach/speech/mento/entity/MentoringPossibleDate.java Outdated Show resolved Hide resolved

Contributor

blacklabf commented Apr 25, 2024

코드리뷰 남겼습니다!

beautiflow added 10 commits

April 26, 2024 11:34


          feat: 엔티티 생성 관련 수정

9cf3017


          feat: 엔티티 생성 정적 팩토리메소드 패턴 적용

6ff987b


          feat: idDelete 에 nullable=false 추가

8c9fe38


          feat: create Member Entity

364f24a


          feat: create Mentor Entity

6bafa1c


          feat: create MentorCareer Entity

09d1dbe


          feat: create MentoringApplication Entity

e0912b9


          feat: create Review Entity

a614aea


          feat: 어노테이션 수정 - @AllArgsConstructor

a1e7121


          feat: 변경 클래스 삭제

31213b2

Kim-AYoung requested changes

View reviewed changes

src/main/java/com/speechpeach/speech/mentoring/entity/Mentor.java Outdated Show resolved Hide resolved

src/main/java/com/speechpeach/speech/mentoring/entity/Mentor.java Outdated Show resolved Hide resolved

src/main/java/com/speechpeach/speech/mentoring/entity/Mentor.java Outdated Show resolved Hide resolved

src/main/java/com/speechpeach/speech/mentoring/entity/MentoringApplication.java Outdated Show resolved Hide resolved

src/main/java/com/speechpeach/speech/mentoring/entity/MentoringPossibleDate.java Outdated Show resolved Hide resolved

src/main/java/com/speechpeach/speech/mentoring/entity/Review.java Outdated Show resolved Hide resolved

beautiflow added 4 commits

April 29, 2024 14:30


          feat: create enum class - MentorCareerPeriod, MentorGenre, MentoringA…

63e4dd2

…pplyStatus, MentoringPossibleDateDay, MentorStatus


          feat: enum class 생성으로 인해 타입 수정

7a13064


          feat: 식별자 값 자동 생성부분 제거

030af91


          chore: 공백 제거

46141fc

Kim-AYoung approved these changes

View reviewed changes

Collaborator

Kim-AYoung left a comment

👍 LGTM

beautiflow added 6 commits

April 29, 2024 23:42


          feat: enum 클래스 필드 한글명으로 변경

417b88f


          feat: CareerLink -> MentorHistory 변경 및 필드 추가

d0029b5


          feat: 필드명 간략하게 수정

d452712


          feat: 정적 팩토리 메서드 네이밍 규칙 of 적용

5ff1954


          feat: MentorMentoringGenre 엔티티 생성

a9ddd86


          feat: enum class 멘토링_장르 수정

0983cc1

Contributor

blacklabf commented Apr 30, 2024

Good Code 😄

blacklabf approved these changes

View reviewed changes

beautiflow and others added 7 commits

April 30, 2024 17:29


          refactor: Member 관련 파일 주석 처리 및 이름 변경(User -> Member)으로 인한 삭제

14048da


          refactor: Member 타입 수정으로 인한 User 타입 파일 주석 및 삭제

b29f984


          refactor: User -> Member 타입 변경 및 관련 필드 수정

7af37f1


          Merge remote-tracking branch 'origin/feature/task-408-create_entity' …

d2139f2

…into feature/task-408-create_entity


          Merge branch 'develop' into feature/task-408-create_entity

2368e6e


          refactor: MemoEntity - YoutubeVideo import 주소 수정

74334b4


          Merge remote-tracking branch 'origin/feature/task-408-create_entity' …

9a1f825

…into feature/task-408-create_entity

github-actions bot commented Apr 30, 2024

📝 Jacoco Test Coverage

Overall Project	23.52% `-44.35%`	🔴
Files changed	32.28%	🔴

File	Coverage
MentorStatus.java	100%	🟢
MentoringPossibleDateDay.java	100%	🟢
MentorCareerPeriod.java	100%	🟢
MentoringGenre.java	100%	🟢
MentoringApplyStatus.java	100%	🟢
BaseEntity.java	25%	🟢
MentorCareer.java	11.11% `-88.89%`	🔴
YoutubeVideoLike.java	11.11% `-51.85%`	🔴
MentoringPossibleDate.java	8.82% `-91.18%`	🔴
MentorHistory.java	8.82% `-91.18%`	🔴
Memo.java	7.32% `-92.68%`	🔴
Record.java	7.32% `-39.02%`	🔴
Member.java	6.67% `-93.33%`	🔴
VideoScript.java	5.45% `-32.73%`	🔴
MentoringApplication.java	4.62% `-95.38%`	🔴
Mentor.java	2.88% `-97.12%`	🔴
MentorMentoringGenre.java	0%	🔴
Review.java	0%	🔴

beautiflow merged commit 24d9be6 into develop

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels