Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK-407] 영상관련 도메인 Entity 생성 #13

Merged
merged 3 commits into from
Apr 30, 2024
Merged

[TASK-407] 영상관련 도메인 Entity 생성 #13

merged 3 commits into from
Apr 30, 2024

Conversation

blacklabf
Copy link
Contributor

workerB

  1. Record, VideoScript, YoutubeVideo, YoutubeVideoLike Entity 작성
  2. 정적팩토리메소드패턴 사용

Description

결과

  • Table 생성 및 컬럼 확인
    image

More

  • entity의 생성자 관련해서 Builder 패턴, 생성자, 정적팩토리패턴 등 다양하게 있는데 저는 유연한 객체 생성 관리를 위해 정적팩토리메소드패턴을 사용했는데 다른 분들은 주로 어떤 방식을 선택하시는지랑 이유가 궁금합니다!

@blacklabf
[Feat] 영상관련 도메인 Entity 작성
04f5297 
1. Record, VideoScript, YoutubeVideo, YoutubeVideoLike Entity 작성
2. 정적팩토리패턴 사용
@blacklabf
[Feat] 영상관련 도메인 Entity 작성
fa45869 
1. Record, VideoScript, YoutubeVideo, YoutubeVideoLike Entity 작성
2. 정적팩토리패턴 사용
@notion-workspace Notion Workspace
Copy link

영상 도메인 Entity 작성

@blacklabf blacklabf added the ✨ Feature 기능 개발 label Apr 24, 2024
@blacklabf blacklabf self-assigned this Apr 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

Test Results

3 tests   3 ✅  0s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 968422b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited
Loading

📝 Jacoco Test Coverage

Overall Project 6.9% -38.1% 🔴
Files changed 9.6% 🔴

File Coverage
YoutubeVideo.java 14.81% -85.19% 🔴
YoutubeVideoLike.java 11.11% -88.89% 🔴
Record.java 7.32% -92.68% 🔴
VideoScript.java 5.45% -94.55% 🔴

@beautiflow
Copy link
Collaborator

beautiflow commented Apr 26, 2024 •
edited
Loading

코드리뷰 남겼습니당!

Kim-AYoung
Kim-AYoung approved these changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@Kim-AYoung Kim-AYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM
❓ 모든 클래스에 대해서 정적 팩토리 메서드 패턴을 사용하셨는데, 클래스를 생성해주는 메서드명에 대한 가독성 때문인가요?
그렇다면 정적 팩토리 메서드 네이밍 규칙을 고려해보시는 것도 좋을 것 같습니다!
제 생각에는 팩터리 메서드의 매개변수들이 그대로 클래스 필드로 구성된다는 점에서 of 네이밍이 적절한 것 같습니다.

@blacklabf
[Refactor] 영상관련 도메인 Entity 수정
968422b 
1. 정적팩토리 메소드 네이밍 규칙 적용
2. 가독성 위해 필드명 수정
@blacklabf
Copy link
Contributor Author

감사합니다! 네이밍 규칙 확인 후, 수정하였습니다.

beautiflow
beautiflow approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@beautiflow beautiflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

src/main/java/com/speechpeach/speech/record/entity/Record.java Show resolved Hide resolved
@blacklabf blacklabf merged commit e9e7a9b into develop Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beautiflow beautiflow beautiflow approved these changes

@Kim-AYoung Kim-AYoung Kim-AYoung approved these changes

Assignees

@blacklabf blacklabf

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blacklabf @beautiflow @Kim-AYoung