-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock FRAM code #286
Merged
Merged
Mock FRAM code #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromehue
force-pushed
the
207-mock-fram-code
branch
from
May 1, 2024 20:15
8dd1f4c
to
ec3dd36
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 86.54% 87.11% +0.56%
==========================================
Files 21 25 +4
Lines 513 613 +100
Branches 7 7
==========================================
+ Hits 444 534 +90
- Misses 69 79 +10 ☔ View full report in Codecov by Sentry. |
jeromehue
force-pushed
the
207-mock-fram-code
branch
3 times, most recently
from
May 1, 2024 20:50
c97f86b
to
472cdd5
Compare
jeromehue
force-pushed
the
207-mock-fram-code
branch
2 times, most recently
from
May 3, 2024 14:19
7c28670
to
fa52476
Compare
PatrickKa
force-pushed
the
207-mock-fram-code
branch
from
May 10, 2024 09:38
75cca8c
to
97dd611
Compare
Also, remove everything related to simulating the FRAM with a file.
PatrickKa
force-pushed
the
207-mock-fram-code
branch
from
May 12, 2024 15:13
3f0c01e
to
a2f9416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FRAM code is mocked according to #200. Apart from empty default do functions, we also provide do functions that simulate the FRAM in RAM. The empty and the RAM do functions are tested in UnitTests/Fram.test.cpp.
Fixes #207