Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of map system updates #327

Merged
merged 24 commits into from
Nov 25, 2024
Merged

Lots of map system updates #327

merged 24 commits into from
Nov 25, 2024

Conversation

Vauff
Copy link
Contributor

@Vauff Vauff commented Nov 23, 2024 •
edited
Loading

  • Added custom cooldowns to maps
  • Added cooldown saving across server restarts/crashes
  • Cooldowns are now triggered by map end
  • Fixed first map not going on cooldown
  • Added minimum and maximum player requirements to maps
  • Added more details to unavailable maps in !nominate list
  • Added a shared function for getting the player count
  • Fixed nomination resetting not working
  • Added changing map by ID with !map if admin already has console access, this still can't be fully allowed due to bad ID's triggering workshop download game crashes
  • Stopped displaying disabled maps in !nominate list
  • Fixed !setnextmap permanently breaking map votes
  • Added better feedback/behaviour to !setnextmap
  • Fixed RTV's not working for a bit when quickly enabled manually at map start
  • Added more detailed error messages to !nominate
  • Added multiple maps warning to !nominate, to fix discoverability of some maps with shared queries (e.g. "fapescape")
  • Fixed another injection possibility in !map

Effectively "part 2" to #225, however there is still more to do, so hopefully part 3 will not also take half a year 😆.

m-arcuri and others added 24 commits November 20, 2024 11:51
@m-arcuri @Vauff
Add individual map cooldown configuration
04fb711 
List cooldown of all maps when running !nominate without having set a nomination
@m-arcuri @Vauff
Add map cooldown saving and loading from file
40a7ff3
@m-arcuri @Vauff
Move processing of map cooldowns to after vote
629c8a3 
This is the same behavour as the map vote system in CS:GO, where the current map will not be set on cooldown until after it is voted off
@Hichatu @Vauff
Min and Max player requirements
875e428
@m-arcuri @Vauff
Update example maplist.cfg
86993f2
@m-arcuri @Vauff
Add Minimum and Maximum player information to !nominate map list when…
e1a20e5 
… requirements are not met
@m-arcuri @Vauff
Use snake case format for min/max player keyvalues in maplist.cfg
48b30f6
@m-arcuri @Vauff
Re-add !mapcooldowns chat command
1f034a2
@m-arcuri @Vauff
Change map cooldown file path
d443709
@m-arcuri @Vauff
Re-add cs2f_vote_maps_cooldown cvar as the default map cooldown
c7b4d3b
@m-arcuri @Vauff
Automatically remove nominations when min/max player count requiremen…
b876eda 
…ts not met
@m-arcuri @Vauff
Fix string format of console messages when loading map list
e994f77
@Vauff
Add shared function for player count
4112401
@Vauff
Fix a possible edge case with KV1 capitalization handling
bd5de19 
Basically, KV1 will cache whichever capitalization gets used first for a string, *globally*.

This previously caused issues with CS:GO's mapchooser cooldown saving, because a map could pack a KV1 cfg with the string "ze_Mako". Then, when we go to save "ze_mako", it will instead be auto-converted to "ze_Mako" because that's what the server used first. So we are just re-implementing the checks to avoid this being an issue.
@Vauff
Fix nomination resetting not working
4601459
@Vauff
Allow changing map by ID if admin already has console access
8c962f9
@Vauff
Make !mapcooldowns print in order again
ccbc86e
@Vauff
Don't show disabled maps in !nominate map list
0eefc31
@Vauff
Fix & update !setnextmap
64a71af
@Vauff
Allow immediate RTV's when enabled manually at map start
3bcaccc
@Vauff
Update GetNeededRTVCount to use GetOnlinePlayerCount
9643cb1
@Vauff
Add more detailed error messages to !nominate
c9a837d
@Vauff
Added warning on several map-related commands for non-unique queries
3dc9155
@Vauff
Adjustments for logging
9517de2 
Improves behaviour with a logging backend.. still need to upstream that :)
@Vauff Vauff enabled auto-merge (squash) November 24, 2024 13:14
@Vauff Vauff merged commit 85af0af into main Nov 25, 2024
3 checks passed
@Vauff Vauff deleted the mapsystem-updates branch November 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faramour Faramour Faramour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vauff @Faramour @m-arcuri @Hichatu