-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add map cooldown and min/max player configuration, saving of map cooldown state #288
Merged
Vauff
merged 12 commits into
Source2ZE:mapsystem-updates
from
m-arcuri:mapvote-cooldown-config
Nov 20, 2024
Merged
Add map cooldown and min/max player configuration, saving of map cooldown state #288
Vauff
merged 12 commits into
Source2ZE:mapsystem-updates
from
m-arcuri:mapvote-cooldown-config
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-arcuri
force-pushed
the
mapvote-cooldown-config
branch
from
October 26, 2024 21:47
7e15a79
to
a13210a
Compare
m-arcuri
changed the title
Add map cooldown configuration and saving/loading of map cooldown state
Add map cooldown and min/max player configuration, saving of map cooldown state
Oct 26, 2024
Vauff
requested changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to remove existing nominations if player count goes out of bounds, and notify those nomination owners.
List cooldown of all maps when running !nominate without having set a nomination
This is the same behavour as the map vote system in CS:GO, where the current map will not be set on cooldown until after it is voted off
… requirements are not met
m-arcuri
force-pushed
the
mapvote-cooldown-config
branch
from
November 17, 2024 16:45
a13210a
to
c46a9b6
Compare
m-arcuri
force-pushed
the
mapvote-cooldown-config
branch
from
November 17, 2024 16:49
c46a9b6
to
65ad87f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new values to maplist.cfg:
"cooldown"
"minPlayers"
"maxPlayers"
Map cooldowns are counted at the end of next map vote instead of at the end of the current one, matching the old CS:GO map manager behaviour.
Using !nominate without any arguments and without having nominated a map will instead list all maps and their cooldowns in console. If a map cannot be nominated due to Min/Max player limits, it will display this information.
Writes cooldown keyvalues to "addons/cs2fixes/configs/cooldowns.cfg" whenever map cooldowns are decremented. This file will be read when the map list is loaded to restore the remaining cooldown lengths from the previous session. If not found, all maps will start as available to nominate.