-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #140 empty context #207
base: master
Are you sure you want to change the base?
Conversation
@danielsussa, thanks for the PR. Since this package and repo appears to be unmaintained, I published your changes to a new package: https://www.npmjs.com/package/@marshallswain/vuedraggable. This project needs a lot of love. If I can find time, I'll update the tooling to use vitest, vite, and vitepress. It definitely needs a TS rewrite, too. |
It looks like the changes break the onDragStart handler., which references |
hey @marshallswain , I will perform some tests with this change with my project. Good to know that you will help to put some love in there! |
I just applied an NPM install using your version! Worked pretty!! |
@marshallswain 感谢,我换成你的包后完美解决draggable与vue3的transition-group不兼容的问题了 |
@marshallswain Thank you very much. However, my .list-enter-active and .list-leave-active classes are not being triggered. Only the .list-move class is being applied when removing or adding elements. code: |
when thiss will be merged? |
Yes I faced the same issue, .list-enter-active and .list-enter-from is not trigger when I add a element to my list. |
Thank you very much |
Hello, I noticed that you released the project on NPM but haven't continued with it. I can help maintain it, or we can create a new repository to take over. I'm already doing this for other public projects. Looking forward to your response. Best regards, |
Search for Vue-draggable-plus. The primary language is Chinese and you can switch the docs to English. Those guys have adopted it and made it great. No need to maintain our own. |
Fix empty node element:
Uncaught (in promise) TypeError: Cannot set properties of null (setting '__draggable_context')
Simple error handler