Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow item with nested sortable to be moved to another item's nested sortable #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow item with nested sortable to be moved to another item's nested sortable #48

wants to merge 1 commit into from

Conversation

filipkis
Copy link

Fixes #44

Basically additional $apply() have been removed. I do not think they add anything.

Small test is included.

@SidIcarus
Copy link

The $apply() in _sync() is needed for letting angularjs know things have changed. It seems to be unable to find the relevant comment node it is expecting whilst dragging from one sortable to another and back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when dropping an item with nested list into a another item with nested list
2 participants
@filipkis @SidIcarus