[Feat] Templator with manifest file check #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
SonyPradana
commented
Nov 8, 2023
SonyPradana
commented
- manifestor, manifest file managger
- manifestor, manifest file managger
prevent unexpected error during caching
anggerpradana
requested changes
Apr 28, 2024
There was a problem hiding this comment.
we need lock file for this feature, to prevent too many render in same time. its also performance issue. I prefer use this for warm up (build cache) it can reduce duplicate, by compiling no change file.
so if this pr cahnge strategy for that may good option to merge.
thank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.