sn32 rgb: yet another major update - more modularity #369

dexter93 · 2024-01-02T15:54:03Z

Decouple key and rgb matrix scanning. Not always required - can live as a standalone rgb driver now
init bugfixes for SN32_PWM_OUTPUT_ACTIVE_LOW
configuration cleanup - everything is now in a header
remove most hardcoded values, inherit and/or calculate instead
driver renamed
added 26x support
introducing individual ( per channel) color correction/ luminosity fine tuning

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fightforlife · 2024-01-03T20:20:03Z

Working good for me on 268F with ROW2COL. But I had two things to change to make it perfect.
Maybe a second board/user would be good to make sure these are no issues on my side/config.

Here I need to use current_key_col vs last_key_col, otherwise the keypress effects are lit one to the left.

qmk_firmware/drivers/led/sn32f2xx.c

Lines 518 to 522 in e3f4c6d

    
           #        if (SN32_RGB_OUTPUT_ACTIVE_LEVEL == SN32_RGB_OUTPUT_ACTIVE_HIGH) 
        
                   writePinHigh(led_col_pins[last_key_col]); 
        
           #        elif (SN32_RGB_OUTPUT_ACTIVE_LEVEL == SN32_RGB_OUTPUT_ACTIVE_LOW) 
        
                   writePinLow(led_col_pins[last_key_col]); 
        
           #        endif // SN32_RGB_OUTPUT_ACTIVE_LEVEL

This is also needed for HARDWARE_PWM. If not included, columns which have not the max amount of keys(rows) will light the last key all the time.

qmk_firmware/drivers/led/sn32f2xx.c

Lines 389 to 391 in e3f4c6d

    
           #    if (SN32_PWM_CONTROL == SOFTWARE_PWM) 
        
                   if (led_index >= SN32F2XX_LED_COUNT) continue; 
        
           #    endif // SN32_PWM_CONTROL

qmk_firmware/drivers/led/sn32f2xx.c

Lines 502 to 504 in e3f4c6d

    
           #    if (SN32_PWM_CONTROL == SOFTWARE_PWM) 
        
                   if (led_index >= SN32F2XX_LED_COUNT) continue; 
        
           #    endif

fightforlife

Tested on K66 v1 with ROW2COL hardware PWM shared matrix.
With these 3 changes it is working very good for me.

drivers/led/sn32f2xx.c

fightforlife · 2024-07-12T14:38:46Z

drivers/led/sn32f2xx.c

    }
    bool enable_pwm_output = false;
    for (uint8_t current_key_col = 0; current_key_col < SN32_RGB_MATRIX_COLS; current_key_col++) {
        uint8_t led_index = g_led_config.matrix_co[current_key_row][current_key_col];
 #    if (SN32_PWM_CONTROL == SOFTWARE_PWM)
-        if (led_index >= SN32F24XB_LED_COUNT) continue;
+        if (led_index >= SN32F2XX_LED_COUNT) continue;


For me this line is necessary also for hardware PWM.
If this is not used the last keys in cols which have less then the standard amount of keys. (e.g. just 4 than normally 5) will light up dimly.

fightforlife · 2024-07-12T14:39:10Z

drivers/led/sn32f2xx.c

@@ -380,7 +500,7 @@ static void update_pwm_channels(PWMDriver *pwmp) {
    for (uint8_t current_key_row = 0; current_key_row < MATRIX_ROWS; current_key_row++) {
        uint8_t led_index = g_led_config.matrix_co[current_key_row][current_key_col];
 #    if (SN32_PWM_CONTROL == SOFTWARE_PWM)
-        if (led_index >= SN32F24XB_LED_COUNT) continue;
+        if (led_index >= SN32F2XX_LED_COUNT) continue;


For me this line is necessary also for hardware PWM.
If this is not used the last keys in cols which have less then the standard amount of keys. (e.g. just 4 than normally 5) will light up dimly.

fightforlife · 2024-07-12T14:41:39Z

drivers/led/sn32f2xx.c

@@ -380,7 +500,7 @@ static void update_pwm_channels(PWMDriver *pwmp) {
    for (uint8_t current_key_row = 0; current_key_row < MATRIX_ROWS; current_key_row++) {
        uint8_t led_index = g_led_config.matrix_co[current_key_row][current_key_col];
 #    if (SN32_PWM_CONTROL == SOFTWARE_PWM)
-        if (led_index >= SN32F24XB_LED_COUNT) continue;
+        if (led_index >= SN32F2XX_LED_COUNT) continue;
 #    endif
        uint8_t led_row_id = (current_key_row * SN32_RGB_MATRIX_ROW_CHANNELS);
        // Check if we need to enable RGB output


In line 519 and 521 I need current_key_col instead of last_key_col.
Otherwise the keypress effects are shifted one col to the left.

// Enable RGB output if (enable_pwm_output) { # if (SN32_RGB_OUTPUT_ACTIVE_LEVEL == SN32_RGB_OUTPUT_ACTIVE_HIGH) writePinHigh(led_col_pins[current_key_col ]); # elif (SN32_RGB_OUTPUT_ACTIVE_LEVEL == SN32_RGB_OUTPUT_ACTIVE_LOW) writePinLow(led_col_pins[current_key_col ]); # endif // SN32_RGB_OUTPUT_ACTIVE_LEVEL }

migrate configs in header

only use custom scanning if the wiring is shared

depending on configuration

…rection

happy new year!

LED output differs depending on the module used, as well as the current limiting setup. Introduce a luminosity correction factor that will limit output on overdriven channels, allowing fine tuning through PWM scaling.

fix ROW2COL PWM bug on COL2ROW A column would light up when pressed on this scenario

dexter93 · 2024-09-13T00:20:41Z

@fightforlife after revisiting this and updating ROW2COL scenario, I could not reproduce your issues. If they persist, they are probably related to indexing on your specific board/setup

github-actions bot added keyboard core labels Jan 2, 2024

dexter93 force-pushed the sn32_rgb_v3 branch 2 times, most recently from 837aee2 to 9989fdc Compare January 2, 2024 18:01

dexter93 force-pushed the sn32_develop branch from 284c7b4 to b01d8aa Compare January 2, 2024 18:12

dexter93 force-pushed the sn32_rgb_v3 branch 5 times, most recently from 257f08e to 456a43a Compare January 3, 2024 09:54

github-actions bot added the stale label Feb 18, 2024

dexter93 removed the stale label Feb 21, 2024

github-actions bot added the stale label Apr 7, 2024

dexter93 removed the stale label Apr 7, 2024

SonixQMK deleted a comment from github-actions bot Apr 7, 2024

github-actions bot added the stale label May 23, 2024

SonixQMK deleted a comment from github-actions bot Jun 5, 2024

dexter93 removed the stale label Jun 5, 2024

dexter93 force-pushed the sn32_rgb_v3 branch from e3f4c6d to 4889fd3 Compare June 20, 2024 11:59

github-actions bot added the dd label Jun 20, 2024

fightforlife suggested changes Jul 12, 2024

View reviewed changes

github-actions bot added the stale label Aug 27, 2024

SonixQMK deleted a comment from github-actions bot Aug 28, 2024

dexter93 added in progress and removed stale labels Aug 28, 2024

dexter93 added 3 commits September 12, 2024 19:26

sn32f24xb rgb: guard for missing SN32_RGB_MATRIX_ROW_PINS

4f2517d

sn32 shared matrix: autodetect if the matrix is shared

c78b92c

migrate configs in header

flesports/fl980: simplify declarations

6be30cf

dexter93 added 15 commits September 12, 2024 19:26

sn32 rgb driver: decouple key from rgb matrix

9c77233

only use custom scanning if the wiring is shared

sn32 rgb driver: make sure init state is off

d07ea53

depending on configuration

sn32 rgb driver: inherit PWM channels from LLD

52d9ee8

sn32 rgb driver: rename sn32f24xb-> sn32f2xx

6c1a92b

sn32 rgb driver: Add sn32f260 series support

4a7826a

sn32 rgb driver: prefer UINT16_MAX instead of hardcoded value

d744438

sn32 rgb driver: fix compilation issue on ROW2COL with COL2ROW PWM di…

ae5311e

…rection

sn32 shared matrix: add missing licence header

f3d97c2

happy new year!

sn32 rgb driver: add individual channel color correction

0ba8d20

LED output differs depending on the module used, as well as the current limiting setup. Introduce a luminosity correction factor that will limit output on overdriven channels, allowing fine tuning through PWM scaling.

drivers: sn32f2xx: simplify name and location

febf5f6

sn32: schemas: rename sn32f2xx rgb driver

16c5a79

sn32 rgb driver: update gpio usage

2da91d0

sn32 rgb driver: fix ROW2COL build

2a5e45f

sn32 rgb driver: correct SN32_RGB_MATRIX_ROWS_HW init

023d7a2

fix ROW2COL PWM bug on COL2ROW A column would light up when pressed on this scenario

sn32 rgb driver: cleanup ROW2COL i/o

93db451

dexter93 force-pushed the sn32_rgb_v3 branch from 4889fd3 to 93db451 Compare September 13, 2024 00:07

sn32 rgb driver: rename more keyboards sn32f24xb-> sn32f2xx

0f31964

dexter93 merged commit bfbfc84 into SonixQMK:sn32_develop Sep 17, 2024
3 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sn32 rgb: yet another major update - more modularity #369

sn32 rgb: yet another major update - more modularity #369

dexter93 commented Jan 2, 2024 •

edited

Loading

fightforlife commented Jan 3, 2024

fightforlife left a comment

fightforlife Jul 12, 2024

fightforlife Jul 12, 2024

fightforlife Jul 12, 2024

dexter93 commented Sep 13, 2024

sn32 rgb: yet another major update - more modularity #369

sn32 rgb: yet another major update - more modularity #369

Conversation

dexter93 commented Jan 2, 2024 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fightforlife commented Jan 3, 2024

fightforlife left a comment

Choose a reason for hiding this comment

fightforlife Jul 12, 2024

Choose a reason for hiding this comment

fightforlife Jul 12, 2024

Choose a reason for hiding this comment

fightforlife Jul 12, 2024

Choose a reason for hiding this comment

dexter93 commented Sep 13, 2024

dexter93 commented Jan 2, 2024 •

edited

Loading