Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SN32F240 system clock and other #58

Open
wants to merge 1 commit into
base: sn32_develop
Choose a base branch
from
Open

Update SN32F240 system clock and other #58

wants to merge 1 commit into from

Conversation

HorrorTroll
Copy link

As titles

@HorrorTroll HorrorTroll requested a review from dexter93 November 27, 2023 15:11
dexter93
dexter93 reviewed Nov 27, 2023
View reviewed changes
Copy link

@dexter93 dexter93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first thoughts

os/hal/ports/SN32/LLD/SN32F2xx/USB/usbhw.h Outdated Show resolved Hide resolved
os/hal/ports/SN32/LLD/SN32F2xx/USB/hal_usb_lld.c Outdated Show resolved Hide resolved
os/hal/ports/SN32/LLD/SN32F2xx/USB/hal_usb_lld.c Outdated Show resolved Hide resolved
os/hal/ports/SN32/LLD/SN32F2xx/USB/hal_usb_lld.c Outdated Show resolved Hide resolved
os/hal/ports/SN32/LLD/SN32F2xx/USB/sn32_usb.h Outdated Show resolved Hide resolved
os/common/ext/SONiX/SN32F2xx/system_SN32F240.c Outdated
void SystemInit (void)
{
void SystemInit (void) {
SN_FLASH->LPCTRL = 0x5AFA0000; /* Disable Slow mode power saving. */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this happen at SYS_CLOCK_SETUP too?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. SONIX don't put them in SYS_CLOCK_SETUP, so probably it doesn't need.

@HorrorTroll
Copy link
Author

Thanks for reviewing, I've just pushed new commit to resolve changes

@dexter93 dexter93 mentioned this pull request Aug 10, 2024
Merged
@HorrorTroll
Copy link
Author

I've removed all new changes related to USB from PR #59, only system clock update now.

@HorrorTroll HorrorTroll changed the title Update SN32F240 USB driver and system clock Update SN32F240 system clock and other Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dexter93 dexter93 dexter93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HorrorTroll @dexter93