Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLE-969: Create integration test with CDT #771

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

thahnen
Copy link
Member

@thahnen thahnen commented Nov 21, 2024

SLE-969

Using simple Makefile-based project for testing the C analysis and configuration in the sub-module.

Additionally, updated the CI components to provide all tools for using gcc/g++/make with Eclipse CDT. A few changes were also necessary as the CI image hasn't been rebuild in months and now misses the WebKit libraries necessary for rendering the SWT browser instance - this is fixed!

@thahnen thahnen force-pushed the task/tha/SLE-969_CdtCi branch 4 times, most recently from dae06e9 to 7046f15 Compare November 25, 2024 11:48
Using simple Makefile-based project for testing the C analysis and configuration in the sub-module.

Additionally, updated the CI components to provide all tools for using gcc/g++/make with Eclipse CDT.

The CI image now needs libwebkit2gtk-4.* as the underlying rendering component of the browser instances used in the SonarQube Rule Description view. Due to Eclipse 4.8 (the oldest target platform) requiring GTK3 - this is not available on the Linux machines on the CI - the RuleDescriptionViewTest was disabled on that axis!
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@thahnen thahnen changed the title (WIP) SLE-969: Create integration test with CDT SLE-969: Create integration test with CDT Nov 25, 2024
@thahnen thahnen marked this pull request as ready for review November 25, 2024 12:34
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice increase in coverage!

See my small comment on the Dockerfile, otherwise LGTM 🚀

ARG NODE_VERSION=20
RUN apt-get update && apt-get install -y metacity xvfb ffmpeg nodejs=${NODE_VERSION}.* gettext-base \
RUN apt-get update && apt-get install -y build-essential metacity xvfb ffmpeg nodejs=${NODE_VERSION}.* gettext-base \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: it's a recommended practice to put each package on a separate line, with \ characters, to make it easier to check the diff when packages are added/removed 🙈

@thahnen thahnen merged commit 30b077e into master Nov 25, 2024
16 checks passed
@thahnen thahnen deleted the task/tha/SLE-969_CdtCi branch November 25, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants