Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable type-checking for Vue.js #4595

Merged
merged 12 commits into from
Mar 20, 2024
Merged

Disable type-checking for Vue.js #4595

merged 12 commits into from
Mar 20, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Mar 13, 2024 •
edited
Loading

Fixes #3876 #4352

Related: #3992

@vdiez vdiez linked an issue Mar 13, 2024 that may be closed by this pull request
Improve performance on Vue.js projects #4352
Closed
zglicz
zglicz reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two suggestions from my side. I will leave it to approval from someone more knowledgeable.

packages/jsts/tests/analysis/analyzer.test.ts Outdated Show resolved Hide resolved
packages/jsts/tests/analysis/analyzer.test.ts Show resolved Hide resolved
@vdiez vdiez requested a review from saberduck March 15, 2024 09:55
yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/jsts/tests/analysis/analyzer.test.ts Outdated Show resolved Hide resolved
@vdiez vdiez enabled auto-merge (squash) March 20, 2024 09:41
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube

@vdiez vdiez merged commit 0c21c6b into master Mar 20, 2024
14 checks passed
@vdiez vdiez deleted the vue-no-typecheck branch March 20, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zglicz zglicz zglicz left review comments

@saberduck saberduck saberduck left review comments

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance on Vue.js projects AnalysisWithWatchProgram should not crash for parsing issues
4 participants
@vdiez @saberduck @zglicz @yassin-kammoun-sonarsource