Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime and compiletime option to disable version checks in gui (… #7650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shelvacu
Copy link

@shelvacu shelvacu commented Dec 3, 2024

Description

This only partially addresses #7291. There is still no option in the gui for this.

Screenshots/Recordings/Graphs

Not sure what screenshots I could take that would be helpful here

Tests

  • rebased on old version (so that the update dialog would trigger)
  • deleted config dir (~/.config/OrcaSlicer)
  • compiled and ran with default options. Confirmed that the update dialog shows up and "do_version_check": true in config file.
  • edited config to "do_version_check": false, update dialog does not show.
  • deleted config dir again
  • compiled and ran, this time passing -DORCA_VERSION_CHECK_DEFAULT=OFF to cmake. Confirmed that the update dialog does not show.

…oftFever#7291)

This only partially addresses SoftFever#7291. There is still no option in the gui for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant