-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reordering and renaming certain menu items #7573
reordering and renaming certain menu items #7573
Conversation
This makes a lot more sence to me, cool! |
Glad you see it that way too. 😊 |
@discip Nice! I always like ergonomic improvements. It's too late to add this idea now that all checks have passed. But perhaps if there's a next time? (I had posted this in early August, but it's gone now.) There is one more item to "unify." The Compare presets feature is not in the same visual order as the Presets to compare. In the Presets, it's Printer at the top, Filament in the middle, and Process at the bottom. Whereas in the Compare presets window, it's Process at the top and Printer at the bottom. (See screen shot.) Confusing. I am guessing that two lines of code could be swapped to unify this? |
@Ergonomicmike This is how it looks now: @SoftFever |
@discip Cool! Thanks! I can see where the printer, filament, material entries were swapped and I could have hacked that part myself. (But I don't know how to do a PR.) But I would totally have missed changing the order of things at line 1845. Glad to have experts here. |
I know logic isn't everything, but it always broke my brain the out of order option hierarchy As someone who prefers the tree style visual layout of old, at least this brings some order to the chaos and its much appreciated, always jarring to see options above others that if not set mean they don't actually do anything (hence the tree layout comment) Experience: I actually fumbled over skirt loops and a few others when I first started a short time ago, wondering why they didn't work |
🤣By no means I'm an expert! I just searched for the specific term and tried changing what ever seemed to fit until it worked. 😊
This is the line that actually made the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* reordered Z-Hop settings * Update Tab.cpp * Update PrintConfig.cpp * reordering **`Compare presets`** to match the layout in the sidebar
Description
With this PR I tried to unify the behavior and appearance of the menu structure so that the entry that controls others is above them.
I hope that makes sense. 😊
Screenshots/Recordings/Graphs
The colored markings are only to indicate the different placement. 😊