Fixes for Xcode 16.0 debugger crashing (with relwithdebinfo) #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiannakas
changed the title
|
Hmm, I'm using VSCode+Ninja on Mac with Xcode 16 installed, it works fine. |
|
Yeap indeed, I am not sure why this started happening now.... Lets keep this one parked just in case it is required in the future? |
|
So I’ve setup a brand new, fresh UTM Vm with 15.1 and this issue is present still. Reopening the Pr as ready to review. |
SoftFever
reviewed
Dec 21, 2024
| @@ -3179,7 +3179,7 @@ void PerimeterGenerator::process_arachne() | |||
| // printf("Layer ID %d, Outer index %d, inner index %d, second inner index %d, maximum internal perimeter %d \n",layer_id,outer,first_internal,second_internal, max_internal); | |||
| if (outer > -1 && first_internal > -1 && second_internal > -1) { // found all three perimeters to re-order? If not the perimeters will be processed outside in. | |||
| std::vector<PerimeterGeneratorArachneExtrusion> inner_outer_extrusions; // temporary array to hold extrusions for reordering | |||
| inner_outer_extrusions.reserve(max_internal - position + 1); // reserve array containing the number of perimeters before a new island. Variables are array indexes hence need to add +1 to convert to position allocations | |||
| inner_outer_extrusions.resize(max_internal - position + 1); // reserve array containing the number of perimeters before a new island. Variables are array indexes hence need to add +1 to convert to position allocations | |||
SoftFever
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes debugger crashes in Xcode 16 due to stricter handling of [sort] irreflexivity violations and stricter control over [vector] memory access. Just slice a simple cube in Orca with Xcode 16 and start the debugger.
Vector access:
Sort irreflexivity
Scheme configuration:
Tests
Testing is needed as well a detailed code review as, while now debugger can run, and I dont see any obvious issues visually, I am not 100% sure of the consequences these three changes may bring.
@Noisyfox @SoftFever would you mind checking these changes when you have time?