Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Commit ID Used for Build in AboutDialog #6516

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

ElectricalBoy
Copy link
Contributor

An amended version of #6036.

Resolves #5935

@ElectricalBoy
Copy link
Contributor Author

ElectricalBoy commented Aug 20, 2024

While I like the idea, I can't stand the text appears there -_-!
Maybe show it only for nightly build?

Originally posted by @SoftFever in #6036 (comment)

0e8cf86 now checks if there is a Git tag that points to the HEAD and enables commit ID display if there is no tag pointing to HEAD (i.e., is a nightly/snapshot build).

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thank you

@SoftFever SoftFever merged commit 091ab68 into SoftFever:main Jan 2, 2025
16 checks passed
@ElectricalBoy ElectricalBoy deleted the build-info branch January 8, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Build Info to About Dialog
3 participants